metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

JavaScript API does not work from within MetaMask's browser

Open php4fan opened this issue 3 years ago • 13 comments

To Reproduce

  1. Go to Browser
  2. Open this url: https://opentarget.org/test/stupid/mm/trans/
  3. Click on the button that says "Send transaction now"

Expected behavior Should prompt me to accept or reject the transaction

Observed behavior Does nothing. If I haven't connected to the website before, it will show the prompt asking me to connect. If the current network is not the BNB Smart Chain, it will prompt me to switch to that network.

But after that (or after none of that if that doesn't apply), it does not ask me to confirm the transaction.

Smartphone (please complete the following information):

  • Device: RedMi Note 10S
  • OS: Android 11
  • App Version - 5.2.0 (913)

to be added after bug submission by internal support / PM Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?

php4fan avatar Jul 03 '22 16:07 php4fan

The exact same thing happens when connecting to another device using WalletConnect:

  • the other device shows QR to connect via WalletConnect
  • in the MetaMask app, I scan the code and connect
  • other device requests transaction

then MetaMask does absolutely nothing.

php4fan avatar Jul 03 '22 18:07 php4fan

What I described above happens about 95% of the time.

Both in the case of using the in-app browser, and in the case of using another device connected throgh WalletConnect, if I retry several dozen times (e.g. clicking frenetically on the "send transaction" button in the example above, many many times), then about 5% of the times, the prompt to confirm the transaction will show up in MetaMask...

....But then, if I confirm the transaction, I get a stupid error saying "Internal JSON-RPC error".

image

image

php4fan avatar Jul 03 '22 19:07 php4fan

No response in 6 days to such a crippling issue??

You'd actually do a better service by not providing an in-app browser at all than providing such a broken one. At least you would't make users waste time trying.

php4fan avatar Jul 09 '22 22:07 php4fan

Hey @php4fan , thank you for report, sorry for taking so long to answer.

Answering the issue of opening https://opentarget.org/test/stupid/mm/trans/ and pressing the send transaction, I'm not being able to reproduce it, everything went fine for me with an android device

tommasini avatar Jul 28 '22 16:07 tommasini

Can you try with an account that has no funds?

I wonder if this is yet another manifestation of https://github.com/MetaMask/metamask-mobile/issues/4646, that is, the fact that when there are not enough funds for the transaction, MetaMask systematically fails to show an error message and just does nothing, immediately closes or just doesn't show up in the first place.

php4fan avatar Jul 28 '22 16:07 php4fan

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Jul 17 '23 18:07 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days.

This is stupid. If no progress is made on an issue for a given amount of time, if anything that's a reason for giving the issue more attention, not for closing it.

php4fan avatar Jul 17 '23 19:07 php4fan

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Oct 15 '23 21:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

Once more, please turn off this stupid thing

php4fan avatar Oct 17 '23 16:10 php4fan

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Jan 29 '24 21:01 github-actions[bot]

And again

php4fan avatar Jan 29 '24 22:01 php4fan

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar May 07 '24 22:05 github-actions[bot]

When will you shut down this stupid bot?

To close an issue because no progress has been made in fixing it is completely idiotic.

php4fan avatar May 08 '24 09:05 php4fan

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 06 '24 10:08 github-actions[bot]

And again.

BTW is this crap still being maintained?

php4fan avatar Aug 06 '24 14:08 php4fan