[FIX] [IMPROVEMENT] keep nft when transaction fail

[tommasini]

Description The problem was the collectible was removed when the transaction started.

Proposed Solution The solution proposed was that the collectible was only removed when the transaction was confirmed. Also, it's proposed here when the transaction it's submitted and we are waiting for feedback from the blockchain, the collectible details will change the Send button for a View Transactions button, which will redirect the user to the Activity View option on the left menu, where he can see the collectible transaction and cancel it or speed it up.

Also sorted the collectible by it's name inside of the collection.

Code Impact Medium, changes the collectible details component and the way that collectibles have in the wallet.

Screenshots/Recordings Small demo of the solution: UPDATE: https://recordit.co/6b8oh8xWLG Test Cases Case1:

• Import collectible
• Transact collectible to another account
• Press the collectible to see the collectible details
• Click on View Transaction Button, will redirect to Activity View
• Cancel the collectible transaction
• Go to wallet
• Verify if can send the collectible again Case2:
• Import collectible
• Transact collectible to another account
• Press the collectible to see the collectible details
• Wait for the transaction ends and touch the modal to the button update

Checklist

• [x] There is a related GitHub issue
• [x] Tests are included if applicable
• [x] Any added code is fully documented

https://github.com/MetaMask/metamask-mobile/issues/2784#issuecomment-1038345711

Solves #2784

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[chrisleewilcox]

I don't see the NFT in my receiving account that I had sent to. Does the NFT need still need to be imported into the receiving account?

[tommasini]

@chrisleewilcox , yes you will need to add in the receiving account too, you can also check in the open sea for test networks if you are using one here

[socket-security[bot]]

Socket Security Pull Request Report

👍 No dependency changes detected in pull request

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Powered by socket.dev

[tommasini]

Closing this PR since it's outdated