metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: unified swaps

Open infiniteflower opened this issue 5 months ago • 2 comments

Description

This PR handles Unified Swaps routing, network, and token selection. It's hidden behind an env var and a feature flag, so there is no risk of accidentally exposing this feature before it's ready.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

infiniteflower avatar Jun 17 '25 19:06 infiniteflower

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 17 '25 19:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2c51102af97a0439b94bf93529599f944167c35f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1eeca6ff-6b13-4dea-bc57-7837a1c861db

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 19 '25 18:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b01cd907dcde1b16bc8feda5acd3c795e02e6467 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe628443-c6f5-40f8-8c2f-0b1d129c80c3

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 19 '25 22:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dfd143bd6140aa9cec6cc445446ce1c7f62f6809 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f897550-3f66-4efc-8556-e78125657899

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 20 '25 19:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6103316996f19230ed60f437f28007fd37c9ab30 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/356ca19c-9476-4b2c-a9b3-5b6428240236

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 20 '25 21:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.77%. Comparing base (09cc376) to head (ab2c173). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...dge/components/BridgeDestNetworkSelector/index.tsx 50.00% 1 Missing and 2 partials :warning:
...dge/components/BridgeSourceTokenSelector/index.tsx 25.00% 0 Missing and 3 partials :warning:
...nts/UI/Bridge/components/BridgeDestNetworksBar.tsx 50.00% 1 Missing and 1 partial :warning:
...ridge/components/BridgeDestTokenSelector/index.tsx 77.77% 1 Missing and 1 partial :warning:
...ents/UI/Bridge/components/TokenInputArea/index.tsx 50.00% 0 Missing and 1 partial :warning:
...ponents/TransactionDetails/BlockExplorersModal.tsx 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16433   +/-   ##
=======================================
  Coverage   72.76%   72.77%           
=======================================
  Files        2739     2739           
  Lines       59551    59577   +26     
  Branches     9406     9409    +3     
=======================================
+ Hits        43333    43355   +22     
- Misses      13465    13466    +1     
- Partials     2753     2756    +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jun 26 '25 17:06 codecov-commenter

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d95a2858d2a2330444d115b8ca363f39eb5e305f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/455381da-7281-422e-bf8f-85714351510c

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 02 '25 20:07 github-actions[bot]

bugbot run

amitabh94 avatar Jul 02 '25 20:07 amitabh94

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ce4cc2b496b17e61d4a400bd511d0c64f5cb7a4a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a8e75779-03c4-44ef-8265-6859165735ba

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 02 '25 20:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7e1d05907df7c36c42d54a4361210d0cc83e6075 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/479f11d2-8be0-4b7b-a91b-83adf522fd70

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 03 '25 02:07 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 476444747430ec8427e21c591ee9aadaf059be05 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/20369bb6-dd32-4eca-b77d-c884c93a5e80

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 03 '25 03:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5bff5a20a72ca349286cabc87d7a109f0cecb2d2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c479e59-0f83-40e3-985f-fd4fa8b189c5

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 03 '25 03:07 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: ccbf1284bf0b034a694d0a3d0b6e58d9dd4a6888 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7460e99d-47ab-4bf7-829b-a8193dcf9eee

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 03 '25 04:07 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: a1e23d9fc236dd1423b96ee8b21e931c9bda7e48 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e3b97de-5762-4cfd-921d-48e7385afb19

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 03 '25 04:07 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 068d06e3bd0a8c60a980db02745faf072f346a4a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef0d05e7-81a8-4a3a-b02a-2bed21a2d374

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 03 '25 04:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b8f68a07c77d33359203caefca28d46e5482d23a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ec15cfb5-270f-4920-87fe-4f66f8b20144

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 03 '25 14:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 33dce3db27d155cd2ad0128dba0d0b5ece5c255c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2bd0a0ef-3f0e-4432-b6f7-ec744db04983

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 04 '25 11:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8a0b699f6f26aa07381c38824a7ebbdfa89c3ff4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/62c05e39-5d34-4a0b-b8cd-314fa8ac5007

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 04 '25 13:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9b7335d4088369dd2630e6d7c3edf3d77e3e083a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/207dde5d-5a91-408c-8204-3d7aee576379

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 04 '25 16:07 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 60a598f83166bec52ced98a040a9309df00f6b81 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/257d2d17-d956-49ca-a887-7006e1c576d1

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 04 '25 18:07 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: e51d6a1957d6c9583b3f3dfae0b9e5f56f956b42 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fbea2705-f6c9-45c6-b8a6-574611f163ff

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 04 '25 19:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ab2c17347c358ab775bb0cd37ba8c4c8e53019b3 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4012774e-3afb-4e48-949a-97aeecdcd362

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 04 '25 19:07 github-actions[bot]

Adding no e2e smoke needed tag because run_wallet_platform_swimlane_android_smoke is also failing on main

bfullam avatar Jul 07 '25 12:07 bfullam

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ff361b1182bc23094225f67c96cc834d6d97e600 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b173a56-329c-43a3-ab42-ce795a276b1f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 08 '25 10:07 github-actions[bot]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​multichain-network-controller@​0.8.0 ⏵ 0.9.097 -11007497 +2100
Updatednpm/​@​metamask/​gas-fee-controller@​23.0.0 ⏵ 24.0.0971007494 +2100
Updatednpm/​@​metamask/​bridge-status-controller@​30.0.0 ⏵ 32.0.097 +110075 +1100 +1100
Updatednpm/​@​metamask/​bridge-controller@​32.2.0 ⏵ 33.0.19610076 +1100 +2100
Updatednpm/​@​metamask/​user-operation-controller@​36.0.0 ⏵ 37.0.097 -11007799 +2100

View full report

socket-security[bot] avatar Jul 09 '25 19:07 socket-security[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b512cd5e39391489b891ce365cda2608b78ffa5b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7cd8cd0c-796a-45b1-9d15-ca925b77ae67

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 10 '25 00:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 743d3d43636e4c4180dfa572b771fb2d50d57a90 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7ac3927b-494a-4c79-8d05-f2371664f16a

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 10 '25 03:07 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ab5eaca993e8d10320f197ba0c698165d9eb52a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/df1d5ad4-33fd-4c4d-afb1-5fbef5443453

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 10 '25 04:07 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
83.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jul 10 '25 04:07 sonarqubecloud[bot]