metamask-mobile
metamask-mobile copied to clipboard
feat(deposit): adds resend otp feature
Description
Adds the ability for a user to resend the provider authentication code if they did not receive one.
- 30 cooldown timer
- support link displayed if user attempts to resend more than 3 times (support link navigation coming in future PR)
Related issues
Fixes:
Manual testing steps
- navigate to otp page and click the resend button
- Confirm you receive another email
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
Attention: Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.
Please upload report for BASE (
feat/deposit/process-kyc-forms@fa16a48). Learn more about missing BASE report.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...mponents/UI/Ramp/Deposit/Views/OtpCode/OtpCode.tsx | 67.64% | 8 Missing and 3 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## feat/deposit/process-kyc-forms #16112 +/- ##
=================================================================
Coverage ? 71.04%
=================================================================
Files ? 2587
Lines ? 55474
Branches ? 8540
=================================================================
Hits ? 39412
Misses ? 13565
Partials ? 2497
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Bitrise
🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄
Commit hash: 1718997274e971ef44a85e22184aa8671fb0707a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0011ee43-3327-4cc5-99b2-83cf86e2d182
[!NOTE]
- This comment will auto-update when build completes
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: 19fc3092456de119c2629518c1c02f4aa72057f7 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5566f6f2-0ad9-4f23-9cac-449934b9ca9f
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: d4ebab2c71655acffaab9c7f8ab53abedee3cc4c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0322bc8e-ff16-4df6-be22-be8c2fa85088
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
[!TIP]
- Check the documentation if you have any doubts on how to understand the failure on bitrise
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: 52baf4150f69adc0dc1a0f32cf34ee3dab41e725 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a7b81101-08f6-4316-ad15-af7abd1c699c
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
4 New issues
0 Accepted issues
Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code