metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: Popular tokens display

Open ziad-saab opened this issue 6 months ago • 17 comments

Description

Display popular tokens in discovery mode when opening a new tab in the browser.

Related issues

Fixes: MMPD-1590

Manual testing steps

  1. Ensure export TOKEN_DISCOVERY_BROWSER_ENABLED="true" is in your .js.env
  2. Go to the browser
  3. Open a new tab, Notice that popular tokens get loaded
  4. Press on a token name, notice navigation to the token details page
  5. Press on the swap button next to a token, notice navigation to the swaps screen

Screenshots/Recordings

Before

https://github.com/user-attachments/assets/994e164d-1c66-4bc6-97b4-c755bdf4cd02

After

https://github.com/user-attachments/assets/7627ca09-9bfc-44b4-9d5b-d9f3de5ae046

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addrex sses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

ziad-saab avatar Jun 03 '25 15:06 ziad-saab

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 03 '25 15:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e88102b4b78ba8e0d6049e9bdbac5046847e2183 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/11169320-43d6-4fe5-9928-af12eb23579c

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 03 '25 15:06 github-actions[bot]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​token-search-discovery-controller@​3.1.0 ⏵ 3.3.0871007295 +3100

View full report

socket-security[bot] avatar Jun 03 '25 15:06 socket-security[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 40a2f30a78aed9f1ecf95f9a728c68b77beec242 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cec0f326-743a-472a-8fb7-0738f9954b69

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 10 '25 22:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e810e8fa894f7e89c68798effe0e7d919fdaea86 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53ee0d56-478c-4d96-8239-f659902b970d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 11 '25 19:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6790da1ecefe15d5a08c18e8abebb918efb5bdd1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d319f8c1-1ce5-4fd1-9d97-a34017a8603b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 11 '25 20:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 88a7aff9762a5300924f413a7d9b79861d754c1f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2d8aa4d-856c-4c70-9bb6-21549f7bec41

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 11 '25 20:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 72ebf94998e0b0eb9067a71845a3dc777e58e516 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91b211f6-3373-4198-bfb0-3f2f8514a379

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 12 '25 00:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d10575bc8af103988e1b2e84e1cafffda41c6b3d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f3712a28-ced4-47a3-9e57-dd66df585156

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 12 '25 15:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 65ccb22276cbdc08eae4be2dd4c8e0a113a718f3 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1aafefa5-7533-4331-866e-371fc36573af

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 13 '25 02:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 70db352cff6369bac6bfc331a3538670102d5e0a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5b5bf5b9-5fb1-4696-9c79-0df9daa67282

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 13 '25 15:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 274bc98a1bec5a3ad95a2e8c90ebfc72e1b0721a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2869531-3b2b-48f9-8452-980e92c959c0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 13 '25 16:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 34bf7b2aec01eb68319d05a7cdbde8b0ee8c12ba Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d56ace71-e14c-4160-9306-ded1c4752d82

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 13 '25 17:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0072c0d0ecbb260c95c94f6c285c6c12c3e5a09e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a940d12c-b715-4ddc-aaaf-d2b5e959d125

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 13 '25 19:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ebb88e87480bf6db5701285b61a3a38c9acb0de0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1d22e379-fd11-4408-a35c-0e245a3c2960

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 17 '25 17:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 78b666404b9b648a4bef100af48d555c3ae6b3c2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7cb6de25-f9ce-4ed0-a20b-3b6f6957a17b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 17 '25 21:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 451774ebfbfa3d2e1d2fc315daf444a7477a92ef Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be81351c-13d0-4dd9-9bf8-78665ff3a983

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 18 '25 03:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1f8e54d35ba40d0042e119c031e6754763ee4f58 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33214e5d-9226-4a1d-a38a-51d17c86c869

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 18 '25 13:06 github-actions[bot]

cc. @darkwing

ziad-saab avatar Jun 18 '25 15:06 ziad-saab

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6da5d96d9dc7c116b0369258b1b0e1253b050b33 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/99795f69-eaac-4c6b-8583-b76cedafad0f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 18 '25 15:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f109046d9e63f814542c303378b53c483af26033 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00051932-8f9a-452d-be7a-92620ccc8da9

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 18 '25 16:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4357a2f02c7e3b1553add80efe04e70609c26e7d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/397bcaf8-0eed-4a22-a00b-4ef54ff64732

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 18 '25 17:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7cd0e6101a15d128fe85f82b2a4203c1b9e9aaeb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd0aa95b-12c3-4e30-aebe-cf84e91a380d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 18 '25 20:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d948872d5097caed9f1140376b86d7dd2023d37d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe11baf6-8bd5-41c2-b723-100c499d2d0b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 18 '25 21:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 85.39326% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (c1693ca) to head (d948872). Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/SearchDiscoveryResult/index.tsx 85.71% 0 Missing and 4 partials :warning:
...archDiscovery/usePopularTokens/usePopularTokens.ts 83.33% 2 Missing and 1 partial :warning:
app/components/UI/BrowserUrlBar/BrowserUrlBar.tsx 33.33% 1 Missing and 1 partial :warning:
app/components/Views/TokenDiscovery/index.tsx 77.77% 2 Missing :warning:
...il/search-discovery/map-moralis-token-to-result.ts 33.33% 0 Missing and 2 partials :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16027      +/-   ##
==========================================
+ Coverage   71.63%   71.85%   +0.21%     
==========================================
  Files        2631     2655      +24     
  Lines       56476    57148     +672     
  Branches     8753     8917     +164     
==========================================
+ Hits        40458    41065     +607     
  Misses      13476    13476              
- Partials     2542     2607      +65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jun 18 '25 21:06 codecov-commenter

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6796f76783f242d91e1f44164db897dd2a8204fe Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb576af4-d208-436f-9042-01e2ad4d0f2a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 19 '25 00:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 38b191dafd8df424dc28b5b811853025431615f1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/20cb38bc-7336-495b-99e8-19b7eec1ab4e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 19 '25 19:06 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: f2070d0a9f3e457e1442085296b6686ddf475c03 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/267934a5-fe5f-4b6a-93f6-81e6a57452e9

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 26 '25 22:06 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jun 26 '25 22:06 sonarqubecloud[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b3b96be1404f3e07aa87c690fe378b62e90a7037 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58a7e068-7063-42de-a1b6-42c3d1a77450

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 26 '25 22:06 github-actions[bot]