metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: upgrade @metamask/eth-ledger-bridge-keyring

Open dawnseeker8 opened this issue 1 year ago • 6 comments

Description

This PR contain the upgrade of @metamask/eth-ledger-bridge-keyring library to latest, which contain the latest @ledgerhq/hw-eth-app from ledger team,

the latest @ledgerhq/hw-eth-app will provide following:

  1. clear-signing feature support
  2. replace @ledgerhq/cryptoassets with lighter package @ledgerhq/cryptoassets-evm-signature

Regarding the package size anlysis from requirement https://github.com/MetaMask/accounts-planning/issues/567 after the upgrade of @ledgerhq/hw-eth-app to 6.39.0, the whole @ledgerhq library bundle did increase a little bit than before. (due to some new features support), but for clear-signing support, we may need to take the hit.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/567

Manual testing steps

Need a full regression on all ledger features to make sure all ledger features not broken by this library upgrade.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

dawnseeker8 avatar Oct 17 '24 12:10 dawnseeker8

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 17 '24 12:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d46c7c1d4cd2b473068d8d2da537bbeacdb27264 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/508e4ca3-7e6d-439c-9f71-34a85c1cc223

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 17 '24 12:10 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ledgerhq/[email protected] None 0 3.1 MB ldg-github-ci
npm/@ledgerhq/[email protected] None +1 431 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 142 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 135 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 2.21 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 108 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 133 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 266 kB aboissiere, gbrahm-ledger, ldg-github-ci, ...5 more
npm/@ledgerhq/[email protected] None 0 377 kB ldg-github-ci
npm/@metamask/[email protected] None +2 423 kB metamaskbot
npm/[email protected] None 0 5.55 kB junderw
npm/[email protected] None 0 779 kB fanatid
npm/[email protected] None 0 64.3 kB piotrwitek

🚮 Removed packages: npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar Oct 17 '24 12:10 socket-security[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 25273a161143f46b090d343eba8574c896b58336 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31c60a9e-0c7b-4e49-b0b3-35611bbe2e4d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 17 '24 13:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1b8e9c4b15b12182f3c00b5feb6a874470c9295a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05e2ec34-881e-4862-86f3-1a2cb70d4287

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 18 '24 13:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fc69511d88f16fc4d2d765bd46507b07b6c1df8f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/517ee319-1c00-4625-96c3-3b50bbcaa210

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 25 '24 02:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d2d9b6a7fc525859585068da5db3b9f5a4e3e12a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8be10453-aabb-4ba2-a005-b58ee2dc3e99

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 25 '24 03:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7b2adeaa7f2829d31f3aa40aee0fa7c2b3d8ba2f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e9c5eaf-58c7-4bd1-ba75-c9df1ff5e4cf

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 07 '24 10:11 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 560278dc12575ba9e9923d1e62ec85b412125c98 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d24461a6-4301-44f5-8377-0e2d1a237eb2

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 07 '24 12:11 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 74ad00f2fad274cd65701d438809baa4adcbe7b5 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28c25e10-75da-4922-b162-34e54a81f4d8

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 07 '24 12:11 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 13122b096406de7242336ebfbb872bbeaf990b02 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e9d046b-0a66-424d-b552-d66a4d1b5228

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Nov 07 '24 13:11 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 43b96c30e61e3568ec06e143e0bce854c87e01ca Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cddf7053-b182-4ef3-8766-69b85b5fd8a0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Nov 07 '24 13:11 github-actions[bot]

Bitrise build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f25cf2d-414a-4ed1-a22a-6fef4cc0e178?tab=artifacts Tested all regression flows on iOS for Ledger and working as expected.

vivek-consensys avatar Nov 08 '24 08:11 vivek-consensys

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d614faf66d9161664f53991d6d8a765ad4f298e0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5ce3959-127a-47b4-a4c2-2c8133e7099a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Nov 08 '24 08:11 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 083091941883c57d10c19f8c0fdd3b3ed6956ad2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/997abcaa-88ee-4eb6-9a1f-95c28a15f350

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Nov 12 '24 01:11 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c9acb3715342286150b158761ad0f6166c72da39 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50922f7d-bcce-4a6d-b54b-2251b2fd1fd5

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Nov 12 '24 01:11 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2bb51e95f1e257b6ec0a984d3aad5c631b8851ec Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e7f50c2-bc87-4b13-8696-da71d7d94491

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 12 '24 06:11 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Nov 12 '24 07:11 sonarqubecloud[bot]

@metamask/eth-ledger-bridge-keyring brings a library that downloads a big file during bundle, do you know if this is still happening?

tommasini avatar Nov 13 '24 09:11 tommasini

@metamask/eth-ledger-bridge-keyring brings a library that downloads a big file during bundle, do you know if this is still happening?

No really, the reason we upgrade is ledger team has do a upgrade on their lib to reduce the size, however, i have checked the whole @ledgerhq library, the size didn't change too much compared to previous version. however, Ledgerhq team plan to release a new version soon. we may need to upgrade that lib again to further reduce the size. anyway we need this PR to be merged so that we can start a clear signing feature

dawnseeker8 avatar Nov 13 '24 09:11 dawnseeker8