metamask-mobile feat(3481): overflow update

trafficstars

Description

The overflow UI is being updated as part of a bigger redesign for the header

Part of this design is the removal of the WalletAccount component. It will no longer be used and can probably be removed. I will confirm and create a follow up PR to remove it.

The WalletAccount component will no longer be used and can probably be removed. I will confirm and create a follow up PR. Because WalletAccount is being removed, the more icon or overflow icon will be moved to the AccountSelectorList. Here is the Figma design

NOTE: This is being merged into my feat-header-update branch and NOT main

Related issues

Feature: #3481

Manual testing steps

Open the wallet homepage.
Tap the account picker to open the bottom sheet.
In the bottom sheet, verify the following for the selected account:
- Edit the account name and confirm changes are saved.
- Check that tapping "View on Etherscan" opens the correct page.
- Use "Share address" and confirm the correct address is shared.
- Verify the correct private key is displayed
If multiple accounts exist:
- Switch between accounts and repeat step 3 for each.
Check overall UI
Verify smooth animations and proper styling.

Changes to `RevealPrivateCredential` component

It now accepts selectedAddress as params to accommodate for the new UI changes. If the params doesn't exist it will fallback to the the selected account that is fetched from the account controller

Select your account
Goto settings from the bottom right icon
Click on "Security & Privacy"
Click on the "Reveal Secret Recovery Phrase" button and go through the flow and verify that is your correct private key

Screenshots/Recordings

Edit Account

Light	Dark

Etherscan

Light	Dark

Before

WIP

After

WIP

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Oct 16 '24 18:10 vinnyhoward

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Oct 16 '24 18:10 github-actions[bot]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8a3c1427f0a22f809feb0da90c37035ff9b57a38 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c43ec5d-c070-4a21-8887-89c551bc7992

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise

Oct 16 '24 18:10 github-actions[bot]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 51fb3fcdb0802be1f401c8826467a99e6304ec56 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31bff964-2244-49d6-b848-cfcdfd5bdd93

[!NOTE]

This comment will auto-update when build completes

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 17 '24 00:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-header-update@65df76f). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...nts/UI/AccountSelectorList/AccountSelectorList.tsx	66.66%	3 Missing and 1 partial :warning:
.../components/List/ListItemSelect/ListItemSelect.tsx	57.14%	2 Missing and 1 partial :warning:
...mponents/Views/EditAccountName/EditAccountName.tsx	62.50%	0 Missing and 3 partials :warning:

Additional details and impacted files

@@                  Coverage Diff                  @@
##             feat-header-update   #11823   +/-   ##
=====================================================
  Coverage                      ?   54.50%           
=====================================================
  Files                         ?     1737           
  Lines                         ?    39274           
  Branches                      ?     4866           
=====================================================
  Hits                          ?    21407           
  Misses                        ?    16377           
  Partials                      ?     1490

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Oct 17 '24 00:10 codecov-commenter

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 953ba828c002b05b6238e92ef6c59b7c51b02b50 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c1d786ee-56d5-48fe-bd0a-9698ddcda348

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise

Oct 17 '24 00:10 github-actions[bot]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 5a64f40ff5a7f035f5985cc0a6f159c2875d324a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e8c1784-ba3a-481f-893a-0ba6ce59abd7

[!NOTE]

This comment will auto-update when build completes

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 17 '24 18:10 github-actions[bot]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6b8aeedabc6dbfcd7d7b7c208467156fc0f4fa06 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a8c9a7b4-7415-4392-bc63-acdc41d22770

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 17 '24 18:10 github-actions[bot]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ec927c6c2539218ef31a86183b940d6a657e435 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d567897-e913-4844-a777-0cc853350752

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 18 '24 17:10 github-actions[bot]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e3bcf42a9ef09a2179ec8723cffab541ca3616b2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c770502b-8efb-4f13-a951-34481303e497

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise

Oct 18 '24 18:10 github-actions[bot]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: be7612b16101c64709960608f6415a13bd6ce1f5 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/994896cc-f3d9-42b4-be2a-2d68ee1c24f3

[!NOTE]

This comment will auto-update when build completes

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 19 '24 21:10 github-actions[bot]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7f1916f039a67ba9de417af552d74ce91c5122ab Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b63ae2b1-7ee6-4c32-b2bc-c0eb153da5ac

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise

Oct 19 '24 22:10 github-actions[bot]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 24ac9535bebb4293c82a02e0e36c6ddf80e1644e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f95b5ce5-4f47-419e-ad47-07e80ecb6ff4

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 21 '24 21:10 github-actions[bot]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: e4111358071daa8e8ec47c78b9145bc0183773ba Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38c4c0f9-96e7-4838-bbb3-b857fa0f3aba

[!NOTE]

This comment will auto-update when build completes

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 22 '24 18:10 github-actions[bot]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 17dbd02aedf609c80dc555ee25ea1e331ce7e77d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2ebad3ce-88a7-4f7a-ab26-d1aca196678d

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 22 '24 19:10 github-actions[bot]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 13ece305acdf4c6a8da2aea111c81577fe910919 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70f72513-f263-481c-aaaa-04756dcf1649

[!NOTE]

This comment will auto-update when build completes

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 24 '24 17:10 github-actions[bot]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bcb561cf94793e6ade2967a3119f8edecf56a11e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06baa0bd-c54a-4c3b-9eb7-77d4e4b2207c