metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat(3448): header update

Open vinnyhoward opened this issue 1 year ago • 13 comments
trafficstars

Description

The header is being updated according to this Figma design (second to last screen).

Because WalletAccount is being removed, the more icon or overflow icon will be moved to the AccountSelectorList. Here is the PR for more info

Related issues

Ticket: #3448

Manual testing steps

  1. Wallet Home Page

    • Open the account picker and switch between accounts
    • Verify functionality remains the same as before

  2. Copy Address

    • Use the copy address feature in the top right
    • Confirm it works as expected

  3. Network Switcher

    • Switch between different networks
    • Ensure all networks load correctly and balances update

  4. Overflow (Edit Account): This is on https://github.com/MetaMask/metamask-mobile/pull/11823

    • Tap on account picker and a bottom sheet will appear
    • Click on the overflow icon (the vertical more icon) and edit your account just like before

Screenshots/Recordings

Light Dark
light_mode_header_update dark_mode_header_update

Before

Light Dark
light_mode_original dark_mode_original

After

Light Dark
light_mode_screenshot dark_mode_screenshot

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vinnyhoward avatar Oct 11 '24 17:10 vinnyhoward

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 11 '24 17:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8a0b55b1f76b8b2cc3c84673d9826f909e5e5dd0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/92e89506-51c2-410c-b3f3-29c4682b0687

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 16 '24 01:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bf53cb4ce1495f2ee4af674e73e57f40eab04853 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/348b6ca8-90e4-43c6-8ce0-d55a256e6675

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 16 '24 15:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 55.57%. Comparing base (ead35c4) to head (0b01463). Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
...nts/UI/AccountSelectorList/AccountSelectorList.tsx 45.45% 5 Missing and 1 partial :warning:
...mponents/Views/EditAccountName/EditAccountName.tsx 62.50% 0 Missing and 3 partials :warning:
app/components/Views/Wallet/index.tsx 50.00% 0 Missing and 2 partials :warning:
app/components/UI/Navbar/index.js 66.66% 1 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11763      +/-   ##
==========================================
+ Coverage   55.35%   55.57%   +0.22%     
==========================================
  Files        1767     1781      +14     
  Lines       39841    40083     +242     
  Branches     4965     4995      +30     
==========================================
+ Hits        22052    22275     +223     
- Misses      16274    16286      +12     
- Partials     1515     1522       +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 16 '24 15:10 codecov-commenter

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fc63b0adb0da138e6bfab99cf80c025569a6a480 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/347fdaf6-6f92-4e1e-83ff-d4af77cade57

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 16 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 65df76fdb9585cda00b450d8281e47496a8625e5 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/acdcd23b-a868-470a-b293-d04abb56549e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 17 '24 00:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5c1b8a31fc5b3871338e8fec771b7c7e8d0a3517 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5b564504-df28-4c15-b507-0685007f05b9

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 17 '24 17:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 490b6b6a642e46378eef922bdf18bfea03356086 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f26501f4-759d-4075-a36c-d5a4ea6c9492

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 17 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6295f728c362e8fe42bf3a0f24fcbe2bab347fc8 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10a5b324-0d21-4ed6-ab34-bdd72c82b37c

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 18 '24 17:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 498de87441dfe44b2310544dfa620a5b22b7726c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/804895b7-d4b4-4c90-a615-36da14a8c78e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 18 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e98d68df3d7dea8b0a50a5735bcf80976ce9ee9d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/18287f10-70d4-48fe-bae7-2549d373ecca

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 18 '24 22:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 266c7c9c4a0919fc6f7cd25192f469f9a4eb1b8b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b9a0036-860f-44bd-a96b-1bd618e8fc7b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 19 '24 21:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8b13549b6093dc11a56b6c8f2be0c2a50cc8bd82 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/124e3172-e210-4a08-be2f-9216404f02e1

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 21 '24 21:10 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 452a6ab8f330f0f21e683f2bf3297172506a0391 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58131ed5-9604-440d-8ce7-2941b79eb616

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 22 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 93fa10030947e6526ce81639be0c773bd2a5e88f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10130901-ab15-492a-82e3-06fb643cad2a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 22 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b862976995d6d5d5417918f5b412a330d9b48e49 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5bd7916b-54c4-410c-8d57-2a1e752334c8

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 23 '24 20:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f910b8c69c5756ec9f67ff0252a01464cc5b5301 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/965097b6-af18-4865-a3cd-1a2a4f1110f7

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 24 '24 02:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 327ed09d4d524f0934fe58b0b0eb271eb70441e7 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f02e01a-1c88-4894-88a9-3e61082fa26f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 24 '24 19:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e1587ee33c52e4f87f29c5b1872ab741ea88455b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b86520ba-ae16-49eb-92c9-73e999f3b300

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 25 '24 16:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 793ef2a6915941909443f9cbba4353a47cba7681 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/de5859c6-a018-4715-9caa-7b3476b6e5a5

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 28 '24 20:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 62dd0c2b6e4a65eb3b186e20c4635ed14798bcb8 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d7cf5fa9-374e-4a7f-aa3d-6ad3d040b637

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 29 '24 17:10 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 6109b9bbff6b39936c201ccafe66078465505a8b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a388b62-44f4-408f-af1b-8f8b0e5e48cd

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 29 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8f43a87df376abad35c81d65d1d16e02e44ef5a6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e2a7b2da-b6fb-4ef9-8862-7b8009591670

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 29 '24 18:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 933ea26c43714c9a167f8f165c8029e5b7a70c60 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/97e73f3d-dac0-4e1a-bf1d-883d1bd1e307

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 30 '24 17:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 52d09ec50956a02b34011b2fa8e6a35e9a24e395 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6aa60d0e-2003-48e9-8ba6-f50c2bb61aa2

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 30 '24 22:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0b014634f4473f2253baac774d8eedd0051739ec Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3fd8120f-d379-4ce3-8873-41efde8f6548

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 31 '24 00:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a0527b5cc5f76cd11be80207e2413f815bf0a70d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/959deee7-c74f-4124-a2c3-6497a4f7ba7d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 02 '24 00:11 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d5ba4a100148f10c525a25597234b103b99a0a5f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/51dc9171-f5e2-42c7-8114-edd8602a8ef6

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 04 '24 17:11 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8b2ffad4ed559b4bc00f8ee8ed25ec016f481098 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d1de4db-11df-40dc-8ba6-c1d3261bc108

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 04 '24 17:11 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bde0d325bf2bb5eaa997c7a1074a180f3c094b0a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10238cf0-3bec-4163-9ec8-ec53cd0a7d8d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Nov 04 '24 19:11 github-actions[bot]