metamask-mobile test: build new Ramps quotes

trafficstars

Description

This tests that the user can change options in the Build Quote screen and build new quotes. The new quotes should show the updated currency/token/fiat/etc.

Related issues

https://consensyssoftware.atlassian.net/browse/RAMPS-1933

Manual testing steps

All Ramps tests are passing:

 PASS  e2e/specs/ramps/onramp.spec.js (185.993 s)
  smokeAssets Buy Crypto
    ✓ should select Region and Payment Method to see the Build Quote screen (17561 ms)
    ✓ should select a new region and check the quotes (44459 ms)
    ✓ should select a new token and check the quotes (35913 ms)
    ✓ should select a new currency and check the quotes (33345 ms)
    ✓ should select a new payment method and check the quotes (33233 ms)

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total

Screenshots/Recordings

Uploading Untitled.mov…

Before

After

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Oct 08 '24 04:10 bkirb

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Oct 08 '24 04:10 github-actions[bot]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: efb98c510573b3cdfc4960b7a95a6401a6f9c217 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b9c11b8-e9e3-46d1-a31e-d9c5a69e1a09

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Oct 08 '24 04:10 github-actions[bot]

I'm concerned about the number of test ids being added, given that we know the default values, would not it be better to assert the presence of the default values by text as described here?

Oct 14 '24 16:10 wachunei

I'm concerned about the number of test ids being added, given that we know the default values, would not it be better to assert the presence of the default values by text as described here?

That makes sense. I removed the testIDs 👍

Oct 15 '24 02:10 bkirb

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.34%. Comparing base (5b1d54a) to head (7f4758d). Report is 44 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11675      +/-   ##
==========================================
+ Coverage   54.07%   54.34%   +0.26%     
==========================================
  Files        1689     1714      +25     
  Lines       38546    39102     +556     
  Branches     4707     4843     +136     
==========================================
+ Hits        20844    21249     +405     
- Misses      16264    16368     +104     
- Partials     1438     1485      +47

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Oct 15 '24 04:10 codecov-commenter

@chrisleewilcox I made some updates to address your feedback and tests are still passing ✅ https://github.com/MetaMask/metamask-mobile/pull/11675/commits/79d4ca10a5359e96dbbbf33e19ac9541ae138377

 PASS  e2e/specs/ramps/onramp.spec.js (227.889 s)
  smokeAssets Buy Crypto
    ✓ should select Region and Payment Method to see the Build Quote screen (16811 ms)
    ✓ should select a new currency and check the quotes (34342 ms)
    ✓ should select a new region and check the quotes (38020 ms)
    ✓ should select a new token and check the quotes (33718 ms)
    ✓ should select a new payment method and check the quotes (29683 ms)

Test Suites: 1 passed, 1 total
Tests:       5 passed, 5 total

Oct 21 '24 04:10 bkirb

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aa9e8127db2a1e4d1196a89cbc17a83f72699522 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d0745c7-250e-42c3-8e20-168ac49dd769