metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat: 7.33.0

Open github-actions[bot] opened this issue 1 year ago • 8 comments

This is the release candidate for version 7.33.0. The changelog will be found in another PR chore/7.33.0-Changelog.

Team sign-off checklist

  • [x] team-security
  • [x] team-platform
  • [x] team-snaps-platform
  • [x] team-sdk
  • [x] team-assets
  • [x] team-notifications
  • [x] team-confirmations
  • [x] team-design-system
  • [x] team-tiger
  • [x] team-wallet-framework
  • [x] team-stake
  • [x] team-accounts

Reference

  • Testing plan sheet - https://docs.google.com/spreadsheets/d/1tsoodlAlyvEUpkkcNcbZ4PM9HuC9cEM80RZeoVv5OCQ/edit?gid=404070372#gid=404070372

github-actions[bot] avatar Oct 04 '24 02:10 github-actions[bot]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 08 '24 13:10 github-actions[bot]

Testing Android V7.33.0 Testing on Samsung A53 Onboarding: custom ETH mainnet

✅ Scenario Outline: Verifying the custom mainnet screen appears ✅ Scenario Outline: Entering an invalid mainnet RPC URL ✅ Scenario Outline: Entering a valid mainnet RPC URL ✅ Scenario Outline: Editing a custom mainnet URL on the settings and privacy view ✅ Scenario Outline: Deleting a custom mainnet URL on the settings and privacy view

Recording: https://drive.google.com/file/d/1dCQfDgVQzx_IMA7-d3kyw0AfaTX1QEO5/view?usp=sharing

Setting: Browser Regression

✅ Browser Scenario 1: Browser Invalid URL ✅ Browser Scenario 2: Navigation with browser controls. ✅ Browser Scenario 3: ENS website loads correctly. ✅ Browser Scenario 4: From the browser, I can successfully upload a picture ✅ Browser Scenario 5: Address bar ✅ Browser Scenario 6: Adding browser Favorites ✅ Browser Scenario 7: Browser Options Menu ✅ Browser Scenario 8: Visiting a malicious website prompts the user with the phishing detection warning ✅ Browser Scenario 9: Navigate to opensea.io, rarible.com, pancakeswap.finance, app.uniswap.org and connect

I took the liberty of modifying some of the test cases because portfolio.metamask.io is the home page now, so it requires manually navigating to home.metamask.io Given that this page will no longer be used, and that is where the favorites list lies, I wonder how this feature will look moving forward.

Recording: https://drive.google.com/file/d/1fH4dXdvFbGqpxI9aZ44R6FeJp-fff8Eo/view?usp=drive_link

Dapp Connection ✅ Connect Wallet to Dapp or Marketplace

Recording: https://drive.google.com/file/d/1fH4dXdvFbGqpxI9aZ44R6FeJp-fff8Eo/view?usp=drive_link

Network Regression ✅ Scenario 1.1: I can remove a custom network (Palm) that was added via the popular network flow ✅ Scenario 1.2: I can remove a custom network that was added via the custom network flow ✅ Scenario 2: Adding a network via a Dapp ✅ Scenario 3: Adding a network via the new popular network flow ✅ Scenario 4: Adding a network via the custom network flow ✅ Scenario 5: Adding a custom network and editing the network

Recording: https://drive.google.com/file/d/1iNRWM35Gl2mL-dYEzeKwcgBtdQWpvEac/view?usp=drive_link

Setting: General view

✅ Scenario: Changing the device language from English to Russian ✅ Scenario: Changing the app language from English to Filipino

Recordings: https://drive.google.com/file/d/1QXAsnvaGkFQf9XrAIfb-RJjnrfylIIUm/view?usp=drive_link https://drive.google.com/file/d/1rRtTiCfshkwkmVc-xMOc9qEuixcEqpBR/view?usp=drive_link

QR Scanner Regression

✅ From the in-app camera I should be able to scan a valid QR code containing an address: ✅ I should be able to use the QR scanner on the send flow to scan an address: https://drive.google.com/file/d/1qAXDAZkLOV5U3mfl7VXhWpI64RQDETJO/view?usp=drive_link ✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message: https://drive.google.com/file/d/1Bm0uk2fuJUU0Z_f6AslkHuyNKDLkvrh2/view?usp=drive_link ✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message: https://drive.google.com/file/d/17SRowWsGOLb2k8iLcjfEY4GxIrtvoLwn/view?usp=drive_link ✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message (the message flickers): https://drive.google.com/file/d/1LJ5KW_ESLqf-BsRu1_REroNtLlvlL25z/view?usp=drive_link ✅ A user can scan a private key QR code using the in-app camera to import an account: https://drive.google.com/file/d/1MNzlMecDdgkLfrS5fjChXk2QiMfi1JKb/view?usp=drive_link ✅ User scans MMM Receive QR code https://drive.google.com/file/d/1ooGcZsOX3i0wfdW-w5A9KpQnUCZ9sc47/view?usp=drive_link

anaamolnar avatar Oct 11 '24 12:10 anaamolnar

Testing IOS v.7.33.0 (1451) on iPhone 15

General view

✅ Scenario: Changing the device language from English to Russian ✅ Scenario: Changing the app language from English to Filipino

Recordings: https://drive.google.com/file/d/1_Ca09ZGBTOH4T1ZzYbtbBc8YBB5_3I9M/view?usp=sharing https://drive.google.com/file/d/10WAKGkJhLD4lFxdZfNEIkVT_Lw_VDcH2/view?usp=sharing

QR Scanner Regression

✅ From the in-app camera I should be able to scan a valid QR code containing an address: ✅ I should be able to use the QR scanner on the send flow to scan an address: ✅ When I scan a dapp QR code using the in-app camera I should see the appropriate warning message: ✅ When I scan a dapp QR code using the QR scanner on the send flow I should see the appropriate error message: ✅ When I scan an invalid address QR code using the QR scanner on the send flow I should see the appropriate warning message: ✅ A user can scan a private key QR code using the in-app camera to import an account: ✅ User scans MMM Receive QR code on different network: ✅Chain ID 1 not found error when scanning Eth receive QR from another network

Recordings: https://drive.google.com/drive/folders/1jkB-x78in_McXO-ADFMQccA7_Bnh_IKs?usp=sharing

Onboarding: custom ETH mainnet

✅ Scenario Outline: Verifying the custom mainnet screen appears ✅ Scenario Outline: Entering an invalid mainnet RPC URL ✅ Scenario Outline: Entering a valid mainnet RPC URL ✅ Scenario Outline: Editing a custom mainnet URL on the settings and privacy view I noticed that after typing the new RPC URL the 'Save' button stays grey, but if you tap on it once, it becomes functional ✅ Scenario Outline: Deleting a custom mainnet URL on the settings and privacy view

Recordings: https://drive.google.com/file/d/1LN_wMBZed0pU8-9ytXH1ZXimjtR4KS0y/view?usp=sharing https://drive.google.com/file/d/14zQTaTHBECvq7JB0tnMO6pGxOVVoCaxz/view?usp=sharing

Browser Regression

✅ Browser Scenario 1: Browser Invalid URL ✅ Browser Scenario 2: Navigation with browser controls. ✅ Browser Scenario 3: ENS website loads correctly. ✅ Browser Scenario 4: From the browser I can successfully upload a picture ✅ Browser Scenario 5: Address bar ✅ Browser Scenario 6: Adding browser Favorites ✅ Browser Scenario 7: Browser Options Menu ✅ Browser Scenario 8: Visiting a malicious website prompts the user with the phishing detection warning ✅ Browser Scenario 9: Navigate to opensea.io, rarible.com, pancakeswap.finance, app.uniswap.org and connect

Recordings https://drive.google.com/drive/folders/1HPu--9VcClQo_S9DaRrBopVoyMvy-4_O?usp=sharing

Dapp Connection

✅ Connect Wallet to Dapp or Marketplace

Recording: https://drive.google.com/file/d/1xLlbOAhoIFT8tG9vsZsshbZHvdizXV5n/view?usp=sharing

Network Regression

✅ Scenario 1.1: I can remove a custom network (Palm) that was added via the popular network flow ✅ Scenario 1.2: I can remove a custom network that was added via the custom network flow ✅ Scenario 2: Adding a network via a Dapp ✅ Scenario 3: Adding a network via the new popular network flow ✅ Scenario 4: Adding a network via the custom network flow ✅ Scenario 5: Adding a custom network and editing the network ⚠️ There is a red sign(the same as the sign that appears on the Test networks) near the MATIC balance on the main screen. After editing the currency from MATIC to POL the red sign disappears. Image ✅ Scenario 6: Editing a popular network

Recordings: https://drive.google.com/drive/folders/1PZ6f8GQYKYrPHdsvj3H_K0-AmnFYqr-C?usp=sharing

Lansky825 avatar Oct 11 '24 12:10 Lansky825

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2e183a5743755b4f2bca25f55e4177ed7a47cbe9 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d613ea99-2cea-4930-ba4c-7cb331514ba5

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 18 '24 18:10 github-actions[bot]

@metamaskbot update-attributions

sethkfman avatar Oct 18 '24 23:10 sethkfman

Attributions update failed. You can review the logs or retry the attributions update here

metamaskbot avatar Oct 18 '24 23:10 metamaskbot

#11913 to fix the diff check CI

NicolasMassart avatar Oct 21 '24 13:10 NicolasMassart

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.23%. Comparing base (5e5190f) to head (deec645). Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11616      +/-   ##
==========================================
+ Coverage   54.65%   55.23%   +0.58%     
==========================================
  Files        1744     1764      +20     
  Lines       39333    39738     +405     
  Branches     4878     4952      +74     
==========================================
+ Hits        21497    21951     +454     
+ Misses      16340    16280      -60     
- Partials     1496     1507      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 23 '24 12:10 codecov-commenter

@metamaskbot update-attributions

sethkfman avatar Oct 24 '24 04:10 sethkfman

Attributions update failed. You can review the logs or retry the attributions update here

metamaskbot avatar Oct 24 '24 04:10 metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 10fb54dbce080f630af695fe0e16d378a61df016 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/49498c65-563a-45b1-ba78-e87663e39fd3

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 24 '24 11:10 github-actions[bot]

@metamaskbot update-attributions

sethkfman avatar Oct 24 '24 14:10 sethkfman

@metamaskbot update-attributions

sethkfman avatar Oct 24 '24 14:10 sethkfman

Attributions update failed. You can review the logs or retry the attributions update here

metamaskbot avatar Oct 24 '24 14:10 metamaskbot