metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat(NOTIFY-1096): add account syncing

Open mathieuartu opened this issue 1 year ago • 15 comments

Description

This PR adds account syncing to MetaMask. As part of profile syncing, with this new feature, users will be able to synchronize all of their accounts and accounts' names across all of their devices.

Related issues

Fixes:

NOTIFY-1096

Manual testing steps

  1. Log in with SRP
  2. Activate profile syncing in preferences
  3. Add new accounts and rename others
  4. Using another browser, log in with SRP
  5. Activate profile syncing in preferences
  6. Watch the magic happen!

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

mathieuartu avatar Sep 13 '24 08:09 mathieuartu

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Sep 13 '24 08:09 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

mathieuartu avatar Sep 13 '24 08:09 mathieuartu

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +2 1.18 MB metamaskbot
npm/@metamask/[email protected] network 0 264 kB metamaskbot
npm/@metamask/[email protected] Transitive: network +2 1.38 MB metamaskbot
npm/@metamask/[email protected] Transitive: environment +2 634 kB metamaskbot
npm/@metamask/[email protected] None 0 210 kB metamaskbot
npm/@metamask/[email protected] None 0 437 kB danfinlay, gudahtt, kumavis, ...8 more
npm/@metamask/[email protected] None 0 1.62 MB metamaskbot
npm/@metamask/[email protected] None 0 1.26 MB metamaskbot
npm/@metamask/[email protected] network +1 1.64 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar Sep 13 '24 08:09 socket-security[bot]

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.58%. Comparing base (ead35c4) to head (d0ce191). Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
app/actions/notification/helpers/index.ts 16.66% 5 Missing :warning:
app/util/notifications/hooks/useAccountSyncing.ts 76.92% 2 Missing and 1 partial :warning:
app/core/Engine.ts 0.00% 2 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11190      +/-   ##
==========================================
+ Coverage   55.35%   55.58%   +0.23%     
==========================================
  Files        1767     1782      +15     
  Lines       39841    40085     +244     
  Branches     4965     4993      +28     
==========================================
+ Hits        22052    22280     +228     
- Misses      16274    16282       +8     
- Partials     1515     1523       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 13 '24 11:09 codecov-commenter

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b9bb37af2eb70f526a91ab72537ffa33ae4eaadc Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2134006d-61ca-4b88-9604-1c8f52146b4d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 13 '24 11:09 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6c9b2cef4d034f3a4f8e49596f2f7509f5a0e8e3 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/79653e7d-5260-497f-b2ed-3cdcf84785e9

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 13 '24 12:09 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ab17435d65392c4fe3b10e8bcb7c54ea71077be0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/362ae0c7-a89a-402c-956b-3c7737d8a7c0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 13 '24 15:09 github-actions[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Sep 19 '24 13:09 socket-security[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fd5615d81c8fc1681ed572cacb81d993cd7c85cb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/876af876-1d9f-4834-b35b-837e9edba87c

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Sep 20 '24 08:09 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f5a2aa94d881922abf8a743c3f890b91f49cc3c6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c089a9fb-6f01-4aec-9bfd-4f53fd986dfa

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 03 '24 11:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b03fd6a1849ac1c6808757b7b0af7c560080ab5d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/573d1eaf-b40c-46ad-9fe2-0ef1accc0601

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 09 '24 07:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c953e4f663bd9e8ed2e51c741e1843a12ccddfda Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7782ae0f-377a-4e66-8fce-788def5ae4a4

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 16 '24 07:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9ca93bade142aea5feb54f625d708719b10dc2bf Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05e21872-7d34-427e-a7ca-99988fd8e5d2

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 17 '24 09:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e4cd362650f61cac663ee1a9080fbc7a56799f70 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b0e9bd5-ea32-44d4-9874-3153f97371f5

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 18 '24 05:10 github-actions[bot]

Did I delete this branch and thus closed this PR by mistake? I'm not sure what happened here... I'm very sorry if I did. I restored the branch and reopened the PR. 🙇🙇🙇🙇🙇🙇🙇

NicolasMassart avatar Oct 23 '24 15:10 NicolasMassart

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3ed226391d94f3043e54666667193ccfeb9961f2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/255e47f1-5656-4351-b744-4f2c1ef2d7e2

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 25 '24 09:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 202e4862e7dba47538933255a3f4d312d97bdf9f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/47e00a96-36bb-431e-affe-584f2479c84f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 25 '24 09:10 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2ab0e9f4ec08285efe97b3ad5c063ad0e338f014 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c6d2db93-6ebe-4d40-afc7-68bafba69a10

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 25 '24 12:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 727375cde34d29b3468f492368c09e93b5765db3 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8673e06-09e1-4d83-a7a5-62b46a2bde39

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 25 '24 12:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bbf692057d6482040f59e95e96a8c26c391e3e9a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28318356-d73e-4728-98f2-71b3370ab566

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 25 '24 13:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0c8aa2e0778d4cb9e498d75f49fd5bd516d75621 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b4113acd-6c9c-471d-8141-259d76cf3b9b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 25 '24 14:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3f53a497a8680d4e5bf3b0733b3870b1f67047eb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d1534c47-034a-4d37-b291-b9be055b7505

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 25 '24 14:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 94561945fd33c25bbe8b0fa86e54379c76c86241 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/adaa7597-35cc-493c-8e62-ec7e48b0eec0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 31 '24 19:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 89cc06bfe7d70b627669d8ddebebb6fc0537a9f4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b8820f3-a128-4f26-8247-5b9e2499d47d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 31 '24 19:10 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 503549771db45d843e06e15e5a74789209b7031b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea43794d-6fce-42ef-a589-7d43d947d686

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Oct 31 '24 21:10 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d0ce1916864f1212f11915b841cbfdca8c6db25e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b27f795-c581-417c-bb2c-33cd4ade2081

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Oct 31 '24 22:10 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 31 '24 22:10 sonarqubecloud[bot]