metamask-mobile
metamask-mobile copied to clipboard
chore: Chore/detect pod diffs
Description
This PR does two things:
- Moves Gemfile into iOS directory, which is where it belongs since it only relates to iOS. We also updated everywhere that calls bundle install or exec so it's calling it in the ios directory
- Run pod install in CI for detecting diffs in Podfile.lock
Related issues
Fixes:
Manual testing steps
- Running
yarn setupstill works normally when run locally - CI passes when run
- CI fails when Podfile.lock is changed when pod install runs in the CI
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using JSDoc format if applicable
- [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: c930d80464fafa1e8c00e8100b50d8261b492617 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d74ea28e-fb3a-4a4e-9283-1d0b03ff4bdc
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
The source pattern needs to be changed from Gemfile* to ios/Gemfile* in the Dockerfile: https://github.com/MetaMask/metamask-mobile/pull/10880/files#diff-94963ca8e27994042fe27476c04b7e6fc496cc470bc24179587449b46905a60aR34
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: f49122dab25f5f21d3c7eed47817c706d619a35a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5e32b02-b5d5-4af5-95d2-223bcaac059e
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 55.75%. Comparing base (
7475ab4) to head (f87c96d). Report is 38 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10880 +/- ##
==========================================
+ Coverage 55.24% 55.75% +0.50%
==========================================
Files 1558 1580 +22
Lines 37153 37627 +474
Branches 4406 4501 +95
==========================================
+ Hits 20527 20980 +453
- Misses 16155 16157 +2
- Partials 471 490 +19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 99f19946a37a38fc7fbc1d282bc0e4453fe81043 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b10ec54-fbee-4386-b0be-24a4923de401
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: f87c96dd84f0fcbe5a461b35de4218ba3845f3c7 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3b21963-7277-4dc4-a5cb-a8007a3967f9
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
[!TIP]
- Check the documentation if you have any doubts on how to understand the failure on bitrise
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: b76866ea9994dc36bcf7fa9df945effd50cdbdea Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b9534e58-2100-4ed3-a759-1288874e9216
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Looks great! Just one thought I had on simplifying the setup.mjs refactor somewhat.
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: fc6238fc9b8c80b7c70aee553c83c68f9cef7bdf Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2a25edc8-6da8-4566-8aec-8711ffdd6de1
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: eced61aeb6baa07d94015aed6edae8ce09d532d6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a15195b-7889-4b61-b936-1c689e96f2df
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
[!TIP]
- Check the documentation if you have any doubts on how to understand the failure on bitrise
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code