metamask-mobile
metamask-mobile copied to clipboard
MetaMask
chore: update eslint v^8.44
Description
This PR aims to update eslint to match extension version and to support the typescript version on mobile and remove this warning:
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0
YOUR TYPESCRIPT VERSION: 5.4.5
There is some things that we need to do to finish this PR:
- [ ] Solve new linter issues
- [ ] Create a pr to @metamask/typescript-eslint-config repo removing a deprecated rule
@typescript-eslint/no-parameter-properties - [ ] Remove the patch to @metamask/typescript-eslint-config
- [ ] Consider keep or not the
@babel/preset-reactto the babel parser config to javascript files - [ ] Discover why app/selectors/accountTrackerController.test.tsx was triggering an issue on eslint
- [ ] Discover why we still have eslint issues here: e2e/pages/Settings/AesCryptoTestForm.ts (maybe we just need to convert it to JS since every e2e file is on JS )
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/[email protected]), npm/@babel/[email protected]), npm/@babel/[email protected]), npm/@babel/[email protected]), npm/@babel/[email protected]), npm/@babel/[email protected]), npm/@babel/[email protected]), npm/@eslint-community/[email protected]), npm/@metamask/[email protected]), npm/@react-native-community/[email protected]), npm/@react-native-community/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected])
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
Ignoring: npm/[email protected]
Next steps
Take a deeper look at the dependency
Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.
Remove the package
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.
Mark a package as acceptable risk
To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all
Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
Project coverage is 52.75%. Comparing base (
8dcdd3c) to head (fc21530). Report is 16 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10865 +/- ##
==========================================
- Coverage 52.75% 52.75% -0.01%
==========================================
Files 1534 1540 +6
Lines 36777 36860 +83
Branches 4335 4357 +22
==========================================
+ Hits 19403 19444 +41
- Misses 16058 16094 +36
- Partials 1316 1322 +6
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: b27124a1ecdee18b3441a784a930c843a884aba7 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/654bc82e-5903-4985-a1d5-f41ab8db6042
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: be044bd2e2fbac632ce2cedfc058fe648d041d63 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8c120b8e-c5c0-451d-9da8-e5f49f06e9e3
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
63.6% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}