metamask-mobile
metamask-mobile copied to clipboard
fix: minimal input must be string
Description
WIP
Related issues
Fixes: #9077
Manual testing steps
- Go to the Send flow
- Select an address to send to.
- Select a token (Select a non Ethereum token)
- Tap the MAX button
- Verify that no errors occur and the maximum amount is correctly displayed
Screenshots/Recordings
NA
Before
NA
After
NA
Pre-merge author checklist
- [x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 360e1ded1f0be4ba0d927dfc766560c510580d85 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b650ff03-adf2-4131-a34e-d46bd9d98261
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: 16adeec021ce76b8a66b2fcbe6dc5f2035ba42fa Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91fec3bd-60cc-410f-a6ef-b73ab50444d0
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
Project coverage is 52.83%. Comparing base (
8dcdd3c) to head (16adeec). Report is 33 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10842 +/- ##
==========================================
+ Coverage 52.75% 52.83% +0.07%
==========================================
Files 1534 1542 +8
Lines 36777 36887 +110
Branches 4335 4361 +26
==========================================
+ Hits 19403 19488 +85
- Misses 16058 16071 +13
- Partials 1316 1328 +12
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: f63062468837ad283807064c91198c5020a9ab5c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86ceea8e-d1ec-4d7c-9ebd-706602019ae6
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 8fa917532e2f21aab8387f02cdbe9475f4b1cf7b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cad85517-75b3-44db-9d51-c598a69b8b4b
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: 3ae5fbbcfdb700d43b6399bba0bc6e8ec4d83008 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6231978a-758b-4836-b1d6-99be5c31e511
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code