metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

fix: minimal input must be string

Open vinnyhoward opened this issue 1 year ago • 3 comments

Description

WIP

Related issues

Fixes: #9077

Manual testing steps

  1. Go to the Send flow
  2. Select an address to send to.
  3. Select a token (Select a non Ethereum token)
  4. Tap the MAX button
  5. Verify that no errors occur and the maximum amount is correctly displayed

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vinnyhoward avatar Aug 27 '24 21:08 vinnyhoward

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 27 '24 21:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 360e1ded1f0be4ba0d927dfc766560c510580d85 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b650ff03-adf2-4131-a34e-d46bd9d98261

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 27 '24 21:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 16adeec021ce76b8a66b2fcbe6dc5f2035ba42fa Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91fec3bd-60cc-410f-a6ef-b73ab50444d0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 04 '24 00:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (8dcdd3c) to head (16adeec). Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
.../UI/Ramp/Views/SendTransaction/SendTransaction.tsx 0.00% 0 Missing and 1 partial :warning:
...nents/Views/confirmations/SendFlow/Amount/index.js 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10842      +/-   ##
==========================================
+ Coverage   52.75%   52.83%   +0.07%     
==========================================
  Files        1534     1542       +8     
  Lines       36777    36887     +110     
  Branches     4335     4361      +26     
==========================================
+ Hits        19403    19488      +85     
- Misses      16058    16071      +13     
- Partials     1316     1328      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 04 '24 00:09 codecov-commenter

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f63062468837ad283807064c91198c5020a9ab5c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86ceea8e-d1ec-4d7c-9ebd-706602019ae6

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 04 '24 19:09 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8fa917532e2f21aab8387f02cdbe9475f4b1cf7b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cad85517-75b3-44db-9d51-c598a69b8b4b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 05 '24 15:09 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3ae5fbbcfdb700d43b6399bba0bc6e8ec4d83008 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6231978a-758b-4836-b1d6-99be5c31e511

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 06 '24 15:09 github-actions[bot]