metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: Eth snap keyring

Open owencraston opened this issue 1 year ago • 4 comments

Description

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/149

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

owencraston avatar Aug 27 '24 00:08 owencraston

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 27 '24 00:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 56.94444% with 31 lines in your changes missing coverage. Please review.

Project coverage is 55.92%. Comparing base (20df5be) to head (abb62cd). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
app/core/Engine.ts 42.85% 16 Missing :warning:
app/core/SnapKeyring/SnapKeyring.ts 66.66% 7 Missing :warning:
app/core/Snaps/SnapsMethodMiddleware.ts 0.00% 6 Missing :warning:
app/core/Snaps/SnapBridge.ts 0.00% 1 Missing :warning:
app/core/Snaps/utils.ts 0.00% 1 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10829      +/-   ##
==========================================
+ Coverage   55.87%   55.92%   +0.04%     
==========================================
  Files        1587     1593       +6     
  Lines       37651    37860     +209     
  Branches     4505     4540      +35     
==========================================
+ Hits        21039    21174     +135     
- Misses      16116    16187      +71     
- Partials      496      499       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 28 '24 21:08 codecov-commenter

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 202 kB metamaskbot
npm/@metamask/[email protected] None 0 133 kB metamaskbot
npm/@metamask/[email protected] None 0 166 kB metamaskbot
npm/@metamask/[email protected] network 0 166 kB metamaskbot
npm/@metamask/[email protected] None 0 76.4 kB gudahtt
npm/@metamask/[email protected] None 0 1.62 MB metamaskbot
npm/@metamask/[email protected] network 0 1.32 MB metamaskbot
npm/@metamask/[email protected] network 0 1.29 MB metamaskbot
npm/@metamask/[email protected] None 0 695 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar Sep 13 '24 19:09 socket-security[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6923c65f0cdf09505d7bf0055b77124eb70fc81 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af4f6e2b-f343-47e8-84cf-d10cfb73d1b9

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 13 '24 23:09 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2ef39a0a0ec315116674cc6f7c5da37aa7cb025b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eefa7b44-040b-4535-8967-d6429b6b0936

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Sep 18 '24 20:09 github-actions[bot]

I updated the human readable versions of the snaps permissions to include snap_manageAccounts and use updated copy for endowment:keyring. These values come from this doc.

Before: Screenshot 2024-09-18 at 1 51 49 PM

After: Screenshot 2024-09-18 at 1 47 32 PM

owencraston avatar Sep 18 '24 20:09 owencraston

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cae529b574ab7fe5dd4b27210974be32f40500e9 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56d5d35c-57a7-482e-a190-c3eca7deda4f

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Sep 19 '24 18:09 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: abb62cd5c4b38d7b178380a1ce850054d8bbef03 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f4be1650-d2f9-4b2c-a41b-be92595d8de9

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Sep 19 '24 20:09 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 363210ff6c0fe1a5a9254c89acd11bf656446bb4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7672a8ce-aeb8-42db-8acf-cca2b7338850

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 19 '24 22:09 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dd28cdb2c26763ea302db25cd2ae078bd366d14f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/51a516fe-dedd-4230-9edd-e01060f0ad69

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 20 '24 00:09 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c107eeac7553615b5113c71a1f01503b0af4243e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd475122-3c36-47c7-b740-b3a91ffc5dc3

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 20 '24 17:09 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a501525531ebdcfa35e1fca56c7e9a4d001f9970 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6604d957-cb0a-441e-8e83-99dcdad1852b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Sep 20 '24 17:09 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8763e211c0cc063481237bdffb376e47d6279872 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/017b8c6d-954f-48d1-a580-6184ac8479fd

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 20 '24 18:09 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Sep 20 '24 18:09 sonarqubecloud[bot]