metamask-mobile
metamask-mobile copied to clipboard
test: complete quiz to reveal SRP
Description
This PR updates the SRP quiz to move it from smoke to regression, includes revealing the SRP text and copying to clipboard. We also make sure that the SRP is not revealed with an incorrect password.
~~Also corrects an earlier spelling mistake in SecurityQuizModal.js~~ Updated selector names used in the earlier SRP quiz test.
Related issues
Fixes: 561
Manual testing steps
On local machine run on this branch...
Android: yarn test:e2e:android:debug:build then yarn test:e2e:android:debug:run e2e/specs/accounts/reveal-secret-recovery-phrase.spec.js
iOS: yarn test:e2e:ios:debug:build then yarn test:e2e:ios:debug:run e2e/specs/accounts/reveal-secret-recovery-phrase.spec.js
pr_regression_e2e_pipeline: PASS Note that regression test that is failing also failed on 8/26 nightly and it not related to my changes here.
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.60%. Comparing base (
7ae10e5) to head (0c54e53). Report is 14 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10754 +/- ##
==========================================
+ Coverage 52.18% 52.60% +0.41%
==========================================
Files 1521 1525 +4
Lines 36452 36592 +140
Branches 4250 4281 +31
==========================================
+ Hits 19023 19249 +226
+ Misses 16162 16037 -125
- Partials 1267 1306 +39
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: 8ca1a753cdc87af4bf3e30ec7048318b5319c97b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a1b225b-e9e9-4981-8c79-58c63273cce1
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code