metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

fix: snap execution environment crypto bug

Open Jonathansoufer opened this issue 1 year ago • 4 comments

Description

This PR group a second round of fixes due test phase on Notification's feature on real devices.

Related issues

Fixes:

  • [x] Turning on notification should take to notification list: NOTIFY-1005
  • [x] Profile Sync toggle is missing during onboarding: NOTIFY-1006
  • [x] No indicator for unread notifications: NOTIFY-1010
  • [x] Notification title misaligned on Android: NOTIFY-1011
  • [x] Missing symbolIn/Out value error on swap: NOTIFY-1014
  • [x] Add missing copy for metrics tracking opt-in: NOTIFY-1004
  • [x] Incorrect privacy notice copy for profile sync & notification: NOTIFY-1007
  • [x] Disabling notification shows an enabling notification alert: NOTIFY-1013
  • [x] Missing Bell badge unread indicator NOTIFY-1012

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Jonathansoufer avatar Aug 21 '24 09:08 Jonathansoufer

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Aug 21 '24 09:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 32.45614% with 77 lines in your changes missing coverage. Please review.

Project coverage is 52.16%. Comparing base (7ae10e5) to head (61036f3). Report is 7 commits behind head on main.

Files Patch % Lines
app/components/Views/Notifications/OptIn/index.tsx 0.00% 18 Missing :warning:
app/lib/snaps/SnapsExecutionWebView.tsx 44.44% 15 Missing :warning:
...nts/Views/Settings/NotificationsSettings/index.tsx 50.00% 9 Missing and 2 partials :warning:
...cationsSettings/NotificationOptionToggle/index.tsx 0.00% 8 Missing :warning:
...asicFunctionalityModal/BasicFunctionalityModal.tsx 40.00% 6 Missing :warning:
app/components/UI/Notification/List/index.tsx 0.00% 5 Missing :warning:
.../Views/OnboardingSuccess/DefaultSettings/index.tsx 42.85% 4 Missing :warning:
...ews/Settings/SecuritySettings/SecuritySettings.tsx 71.42% 0 Missing and 2 partials :warning:
app/util/notifications/methods/common.ts 0.00% 1 Missing and 1 partial :warning:
...ents/UI/Notification/NotificationMenuItem/Icon.tsx 0.00% 0 Missing and 1 partial :warning:
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10726      +/-   ##
==========================================
- Coverage   52.18%   52.16%   -0.03%     
==========================================
  Files        1521     1522       +1     
  Lines       36452    36603     +151     
  Branches     4250     4288      +38     
==========================================
+ Hits        19023    19094      +71     
- Misses      16162    16225      +63     
- Partials     1267     1284      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 22 '24 23:08 codecov-commenter

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1de04a0470f9d38c4fcbfac70696e22967c4205e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3880cd04-5aec-4f51-a8da-69d40aae5c3e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 23 '24 09:08 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
38.4% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Aug 26 '24 10:08 sonarqubecloud[bot]