chore: move detox-cli from globally installed to devDependencies

[legobeat]

trafficstars

• The package detox-cli is being declared and installed as part of devDependencies, instead of via yarn global add in setup.mjs.
• Remove redundant setup:detox-e2e package script
• ci: Skip applesimutils installation for bitrise android e2e

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security[bot]]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	eval, filesystem	0	55.8 kB	asafkorem
npm/[email protected]	environment, eval, filesystem, network, shell, unsafe	0	13.2 MB	wix.mobile

🚮 Removed packages: npm/[email protected]

View full report↗︎

[socket-security[bot]]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[legobeat]

@SocketSecurity ignore npm/[email protected]

[cortisiko]

@legobeat, I recently merged a PR that removed detox from the setup script. Having detox cli as a dev dependency makes sense. Perhaps resolve the conflict with main on this PR and we can aim to get this merge

[legobeat]

@cortisiko Rebased.

Might I ask, why was the approach (installing it globally in bitrise, and leaving it as exercise for the dev elsewhere) in #10553 preferred over this PR (install it through devDependencies in every environment, like any other devdep)?

[cortisiko]

@cortisiko Rebased.

Might I ask, why was the approach (installing it globally in bitrise, and leaving it as exercise for the dev elsewhere) in #10553 preferred over this PR (install it through devDependencies in every environment, like any other devdep)?

@legobeat ah, hmmm, so I wasn't aware you had opened this PR, so it wasn't a matter of preference. Installing Detox as a dev dependency makes sense to me. Before merging this PR, Can we kick off an e2e test build on bitrise for good measure?

[legobeat]

@cortisiko Rebased. Might I ask, why was the approach (installing it globally in bitrise, and leaving it as exercise for the dev elsewhere) in #10553 preferred over this PR (install it through devDependencies in every environment, like any other devdep)?

@legobeat ah, hmmm, so I wasn't aware you had opened this PR, so it wasn't a matter of preference. Installing Detox as a dev dependency makes sense to me. Before merging this PR, Can we kick off an e2e test build on bitrise for good measure?

Makes sense.

Bitrise E2E kicked off.

[cortisiko]

oooooo @legobeat the e2e tests are not going to run on a fork. Can you open the PR the mobile repo?

[legobeat]

@cortisiko Ah, I forgot the integration is still WIP on this repo...

Just triggered it manually here (rf commit hash).

It seems that the SonarCloud CI job is still broken and needs addressing but can be bypassed? Any concerns wrt that for this PR?

[cortisiko]

@legobeat seems like the build failed again. to confirm detox-cli-devdeps is the PR you are working on?

It seems that the SonarCloud CI job is still broken and needs addressing but can be bypassed? Any concerns wrt that for this PR?

I wouldn't say Sonar is broken, perhaps it is a limitation on running against forks? Not sure. But in this instance, we can ignore it for now.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.80%. Comparing base (b9dbf4d) to head (ecf8b1a). Report is 56 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10449      +/-   ##
==========================================
- Coverage   55.84%   53.80%   -2.05%     
==========================================
  Files        1594     1639      +45     
  Lines       37855    38180     +325     
  Branches     4545     4627      +82     
==========================================
- Hits        21142    20541     -601     
- Misses      16214    16226      +12     
- Partials      499     1413     +914     

Flag	Coverage Δ
	53.80% <ø> (-2.05%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[legobeat]

@Cal-L: Passing bitrise run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d58b4ec-72d9-4e3e-b1e9-020db0639848

detox-cli is just a shim for the detox binary provided by package depenedncy detox so it can actually be fully removed.