metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

feat: create redux slice for featureFlags

Open frankvonhoven opened this issue 1 year ago • 6 comments
trafficstars

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

frankvonhoven avatar Jul 12 '24 22:07 frankvonhoven

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jul 12 '24 22:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Project coverage is 49.72%. Comparing base (dcce5a8) to head (41e6188).

Files Patch % Lines
app/store/sagas/index.ts 33.33% 8 Missing :warning:
app/core/redux/slices/featureFlags/index.ts 46.15% 7 Missing :warning:
app/store/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10294      +/-   ##
==========================================
- Coverage   49.73%   49.72%   -0.01%     
==========================================
  Files        1451     1452       +1     
  Lines       34922    34948      +26     
  Branches     3956     3957       +1     
==========================================
+ Hits        17367    17377      +10     
- Misses      16451    16467      +16     
  Partials     1104     1104              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 12 '24 22:07 codecov-commenter

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 26e05d070e17a70d85d07e1078e6b6a43237eeb8 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/211bc12c-d6cf-4769-8068-3b424686c3c4

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 23 '24 17:07 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 5d6afbd8d9b74f1ccee46549b786b6c1e9e3e219 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e243717-ad11-4662-a57c-5ece748da802

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 23 '24 19:07 github-actions[bot]

We can update this branch with main to have the audit:ci pipeline fixed, also, could we add a PR description?

tommasini avatar Sep 12 '24 21:09 tommasini

Ah it seems unit tests and tsc issues :(

tommasini avatar Sep 13 '24 18:09 tommasini

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d4e8c0aeb9d04f2e584f8f14187a27f2e4b30e42 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d804ca1a-4d35-4bf6-8921-e8ec432ed054

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Sep 17 '24 18:09 github-actions[bot]