metamask-mobile
metamask-mobile copied to clipboard
feat: create redux slice for featureFlags
Description
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.
Project coverage is 49.72%. Comparing base (
dcce5a8) to head (41e6188).
| Files | Patch % | Lines |
|---|---|---|
| app/store/sagas/index.ts | 33.33% | 8 Missing :warning: |
| app/core/redux/slices/featureFlags/index.ts | 46.15% | 7 Missing :warning: |
| app/store/index.ts | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #10294 +/- ##
==========================================
- Coverage 49.73% 49.72% -0.01%
==========================================
Files 1451 1452 +1
Lines 34922 34948 +26
Branches 3956 3957 +1
==========================================
+ Hits 17367 17377 +10
- Misses 16451 16467 +16
Partials 1104 1104
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 26e05d070e17a70d85d07e1078e6b6a43237eeb8 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/211bc12c-d6cf-4769-8068-3b424686c3c4
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code
Bitrise
🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄
Commit hash: 5d6afbd8d9b74f1ccee46549b786b6c1e9e3e219 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e243717-ad11-4662-a57c-5ece748da802
[!NOTE]
- This comment will auto-update when build completes
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
We can update this branch with main to have the audit:ci pipeline fixed, also, could we add a PR description?
Ah it seems unit tests and tsc issues :(
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: d4e8c0aeb9d04f2e584f8f14187a27f2e4b30e42 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d804ca1a-4d35-4bf6-8921-e8ec432ed054
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
63.9% Coverage on New Code
0.0% Duplication on New Code