metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters

Open tommasini opened this issue 1 year ago • 12 comments

Description

This PR is blocked due to breaking changes on the errors thrown to the dapps. More info in this thread

This PR includes:

Related issues

Fixes:

Manual testing steps

  1. Go to in-app browser
  2. Test connect with multiple dapps
  3. Perform transaciton on test dapp

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/46944231/c608d957-6684-40e2-8963-67a11dc610df

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

tommasini avatar Jun 24 '24 21:06 tommasini

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 24 '24 21:06 github-actions[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Jun 24 '24 21:06 socket-security[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c6e47edecbb33ca933d7fa25965e7c8f81817f75 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5cd3b4ea-3953-4e13-b096-d6d52802d5ba

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 24 '24 21:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ddfb55d9b187e74463d74ddabf94764944ce86c9 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbb6471d-e11b-4189-bd15-75232ee82fed

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 25 '24 00:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 49cf6fa10ded0c7f305ca078e45a23b88214b4ff Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5bf5805-162b-4412-9712-f77192432d9d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 25 '24 01:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 010a194c05c75c90cd96a6d569f62adac5d2b238 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/36deec35-0dff-4470-a857-54329d86cdf0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 25 '24 09:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b7b8f28bf0022cc94b4912dc191ae2d735ca0698 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/34830c05-7d3b-42d3-b326-bc50fac8350a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 25 '24 14:06 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0debc0505a91d14bb9a9f9c6840555561310d340 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f5aa28d3-d608-4e2e-a025-41dd07661ca6

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jun 25 '24 15:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.49%. Comparing base (b013c71) to head (0debc05). Report is 122 commits behind head on main.

Files Patch % Lines
app/core/WalletConnect/WalletConnectV2.ts 0.00% 2 Missing :warning:
app/core/BackgroundBridge/BackgroundBridge.js 66.66% 1 Missing :warning:
app/core/Snaps/SnapBridge.ts 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10098      +/-   ##
==========================================
+ Coverage   47.24%   49.49%   +2.24%     
==========================================
  Files        1370     1427      +57     
  Lines       33304    34420    +1116     
  Branches     3586     3801     +215     
==========================================
+ Hits        15736    17035    +1299     
+ Misses      16607    16323     -284     
- Partials      961     1062     +101     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 25 '24 15:06 codecov-commenter

Did a light check on SDK and it seems to be all good ✅

christopherferreira9 avatar Jun 26 '24 10:06 christopherferreira9

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 26 '24 08:09 github-actions[bot]

This has been picked up in #11952

legobeat avatar Oct 28 '24 05:10 legobeat