metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: new receive flow

Open jonybur opened this issue 1 year ago • 32 comments

Description

Changes the QR/Receive screen flow. Unifies the QR code and the Receive screen. Makes the new screen show up as a standalone screen.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2384

Manual testing steps

  1. Go to each one of the triggers that open up the Receive screen
  2. Test that the screen opens, and that it opens on the correct screen.

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/11148144/ac6343d3-fc64-4f3c-8d25-9a5c4ced2b06

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jonybur avatar Jun 21 '24 11:06 jonybur

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 21 '24 11:06 github-actions[bot]

@yanrong-chen This is ready for your review. Please note that the QR got is not using dots as in the design. That would require a larger change.

hesterbruikman avatar Jun 27 '24 09:06 hesterbruikman

@plasmacorral This PR updates QR code scanning and makes it part of a shared 'Receive' and 'Scan' flow. Could we kindly ask for your support to test this update against key import scanning, keystone use, etc.?

hesterbruikman avatar Jun 27 '24 09:06 hesterbruikman

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 69442423e7279002af79614c53096319870d1201 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e03aa19-aba0-4c62-ac83-ea63ac781fe2

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 08 '24 22:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8709b7c09d80cd6a8869418d0e9cf16497d9d45b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f62aa2fe-f435-4868-9b5c-fc96ebcf65d0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 09 '24 02:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: faf3b9e24ba1b27f02ff81d963981c4790c871e6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/99944097-a0f7-4be8-ba14-4c19f1435b99

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 09 '24 12:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d7a2c8f0e13255fcfe352c5a70213f6d0f69afb0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a592b31f-d669-41a8-9459-1e6d12004d1e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 15 '24 14:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b03285558a08cd1efc316310ce05ad16693c517a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00e6f89e-7b4f-40c7-98ab-74cd076528b6

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 15 '24 14:07 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9b8489d639ffd7c0ad8354060bed526223b7360d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b887861-6a99-4895-a657-6b222d1956b4

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Jul 16 '24 22:07 github-actions[bot]

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jul 16 '24 22:07 sonarqubecloud[bot]

I've tested this component looks great (android) 🎉

sahar-fehri avatar Jul 18 '24 09:07 sahar-fehri

getting the error below for a physical device ( iphone 14 )

https://github.com/user-attachments/assets/7175762a-2769-463b-9f36-19f39d5f4ec8

salimtb avatar Jul 18 '24 10:07 salimtb

can we add an e2e test for this feature ?

salimtb avatar Jul 18 '24 10:07 salimtb

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 58be86d504d6abbbb92ebadc0b111cdaaa36f1df Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b72c2d5c-1746-4a52-9ef9-14355bdb6423

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 15 '24 02:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 164074d5d34233a454d6892cd815b3b90c50f42f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e913cd74-8340-49c8-953a-10d3ff77d766

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 15 '24 02:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3aae6b87c31d9de8d8d00f0ea264ee74a9440133 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd0f40dd-079f-4172-bc77-e7be3e2e16c0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 16 '24 14:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 416ccbfbb12c2481a64735ab678d5af220b4b7a5 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4d26c5e8-df7c-48d1-ab65-c54f985bd9d5

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 16 '24 14:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 62.31884% with 26 lines in your changes missing coverage. Please review.

Project coverage is 55.22%. Comparing base (8dcdd3c) to head (64a6314). Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
...p/components/Views/QRTabSwitcher/QRTabSwitcher.tsx 53.33% 9 Missing and 5 partials :warning:
...iews/QRAccountDisplay/QRAccountDisplay.stories.tsx 0.00% 3 Missing :warning:
...p/components/Views/WalletActions/WalletActions.tsx 0.00% 2 Missing :warning:
app/components/UI/AssetOverview/AssetOverview.tsx 0.00% 1 Missing :warning:
app/components/UI/DrawerView/index.js 0.00% 1 Missing :warning:
app/components/UI/Navbar/index.js 0.00% 1 Missing :warning:
app/components/UI/ReceiveRequest/index.js 50.00% 1 Missing :warning:
...ents/Views/ImportFromSecretRecoveryPhrase/index.js 0.00% 1 Missing :warning:
app/components/Views/ImportPrivateKey/index.tsx 0.00% 1 Missing :warning:
app/core/RPCMethods/RPCMethodMiddleware.ts 0.00% 1 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10061      +/-   ##
==========================================
+ Coverage   52.75%   55.22%   +2.46%     
==========================================
  Files        1534     1559      +25     
  Lines       36777    37152     +375     
  Branches     4335     4411      +76     
==========================================
+ Hits        19403    20516    +1113     
- Misses      16058    16160     +102     
+ Partials     1316      476     -840

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 16 '24 14:08 codecov-commenter

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 76c1bb92f3ed063d6213c5182681776b4ef46e93 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8096c7c-7f38-4472-a529-3e3d84182895

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 19 '24 11:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c9778c6d1e9fff7d48e812c28c49d3d185924165 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/72a056a5-8d95-443a-ac32-69655ff37278

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 22 '24 16:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 51dd5de51a8a70c1f60caf7e48a57b1ce6178ec0 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d1ff587-fefe-454b-a38b-0eb9c4a42e19

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 23 '24 16:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6ec28d1e0d2ce66b077736d793bbe1c8710efaee Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/48440110-2c21-4116-8168-35daeb51a6a0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 27 '24 12:08 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 6e9e14c60a7b2f0c2c130b84ea6ae2e5bd72288e Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/12106f95-3cc8-4bd4-8e4f-c6f737e4a839

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 27 '24 16:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 99be1de5de1f422c269c2669f177659cc113b6d1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7acab3c0-575c-4584-8aa3-1f549aff6c91

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 27 '24 16:08 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2297c363763d45fa130593cf0b3936a9c43074fc Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ae27fdd7-6b3d-4075-8cb9-1fa4734a1081

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 27 '24 23:08 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: dd6351dfcf1b1deaf4585a604e93b087a37d455c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2c8a0f6-5204-4bb0-8f3c-42f8a9031b4d

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 27 '24 23:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2a1916aa795e49f19d2ebb9f53522aa711c0a21c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b866fef3-f1d6-42ac-a508-6389aa710f85

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 27 '24 23:08 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: aca55a72957a281a06ee28f3ea2ce5adffbd7ce1 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d2bbee8-55b1-4202-84d3-255055cccacf

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 28 '24 18:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 286d90672580a39354c841959df9ff4825c252cb Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9bbf38aa-3e05-4e00-b7ec-60a5e3e7a37e

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 28 '24 18:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a067e181817f44423a2b90db71b2246c1a54fb65 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17c3aa15-13cc-4ea1-ad79-ea76e452775b

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 28 '24 19:08 github-actions[bot]