metamask-extension
metamask-extension copied to clipboard
build: bump `@metamask/[email protected]`
Description
This will remain a draft until we publish @metamask/[email protected]
https://github.com/MetaMask/core/pull/5978
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
| Diff | Package | Supply Chain Security |
Vulnerability | Quality | Maintenance | License |
|---|---|---|---|---|---|---|
| @metamask/assets-controllers@68.0.0 ⏵ 68.2.0 |
Builds ready [3954680]
- builds: chrome, firefox
- builds (beta): chrome, firefox
- builds (flask): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- bundle size: Bundle Size Stats
- user-actions-benchmark: User Actions Stats
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
UI Startup Metrics (1211 ± 55 ms)
| Platform | BuildType | Page | Metric | Mean (ms) | Min (ms) | Max (ms) | Std Dev (ms) | P 75 (ms) | P 95 (ms) |
|---|---|---|---|---|---|---|---|---|---|
| Chrome | Browserify | Home | uiStartup | 1211 | 1107 | 1331 | 55 | 1254 | 1303 |
| load | 1050 | 942 | 1205 | 54 | 1091 | 1135 | |||
| domContentLoaded | 1044 | 937 | 1198 | 54 | 1083 | 1130 | |||
| domInteractive | 17 | 13 | 36 | 5 | 16 | 33 | |||
| firstPaint | 812 | 86 | 1197 | 387 | 1072 | 1132 | |||
| backgroundConnect | 7 | 4 | 30 | 3 | 7 | 9 | |||
| firstReactRender | 21 | 16 | 47 | 5 | 21 | 31 | |||
| getState | 13 | 6 | 40 | 7 | 18 | 28 | |||
| initialActions | 0 | 0 | 1 | 0 | 0 | 1 | |||
| loadScripts | 796 | 699 | 946 | 51 | 828 | 882 | |||
| setupStore | 8 | 6 | 26 | 3 | 8 | 14 | |||
| Webpack | Home | uiStartup | 2064 | 1634 | 2540 | 223 | 2210 | 2458 | |
| load | 1621 | 1270 | 2010 | 187 | 1735 | 1943 | |||
| domContentLoaded | 1615 | 1265 | 2006 | 186 | 1730 | 1937 | |||
| domInteractive | 16 | 11 | 87 | 13 | 13 | 50 | |||
| firstPaint | 166 | 63 | 643 | 79 | 191 | 332 | |||
| backgroundConnect | 20 | 13 | 36 | 5 | 22 | 32 | |||
| firstReactRender | 139 | 47 | 385 | 106 | 161 | 349 | |||
| getState | 11 | 5 | 24 | 4 | 12 | 18 | |||
| initialActions | 3 | 1 | 5 | 1 | 3 | 4 | |||
| loadScripts | 1612 | 1263 | 1996 | 184 | 1729 | 1926 | |||
| setupStore | 36 | 7 | 317 | 76 | 18 | 300 | |||
| Firefox | Browserify | Home | uiStartup | 1292 | 1161 | 1538 | 77 | 1341 | 1449 |
| load | 1148 | 1035 | 1367 | 74 | 1195 | 1313 | |||
| domContentLoaded | 1148 | 1035 | 1367 | 74 | 1195 | 1313 | |||
| domInteractive | 95 | 35 | 176 | 24 | 107 | 136 | |||
| firstPaint | NaN | NaN | NaN | NaN | NaN | NaN | |||
| backgroundConnect | 20 | 13 | 120 | 12 | 19 | 30 | |||
| firstReactRender | 23 | 20 | 53 | 4 | 23 | 27 | |||
| getState | 7 | 4 | 39 | 4 | 8 | 9 | |||
| initialActions | 0 | 0 | 7 | 1 | 0 | 1 | |||
| loadScripts | 1130 | 1020 | 1353 | 70 | 1177 | 1276 | |||
| setupStore | 6 | 4 | 40 | 4 | 6 | 11 | |||
| Webpack | Home | uiStartup | 1495 | 1367 | 1743 | 93 | 1550 | 1702 | |
| load | 1299 | 1191 | 1562 | 89 | 1354 | 1499 | |||
| domContentLoaded | 1299 | 1190 | 1562 | 89 | 1354 | 1498 | |||
| domInteractive | 77 | 33 | 163 | 18 | 83 | 118 | |||
| firstPaint | NaN | NaN | NaN | NaN | NaN | NaN | |||
| backgroundConnect | 21 | 15 | 44 | 5 | 22 | 36 | |||
| firstReactRender | 41 | 27 | 52 | 4 | 43 | 48 | |||
| getState | 10 | 5 | 66 | 9 | 9 | 30 | |||
| initialActions | 0 | 0 | 2 | 1 | 1 | 1 | |||
| loadScripts | 1280 | 1173 | 1543 | 90 | 1336 | 1475 | |||
| setupStore | 8 | 5 | 72 | 8 | 8 | 13 |
Benchmark value 37 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2459 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Sum of mean exceeds: 20ms | Sum of p95 exceeds: 240ms
Sum of all benchmark exceeds: 260ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0%)
- ui: 0 Bytes (0%)
- common: 754 Bytes (0.01%)