metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix(deps): [email protected]>~2.6.0

Open legobeat opened this issue 1 year ago • 2 comments

Description

  • fix(deps): [email protected]>~2.6.0
    • 2.7.0 updates to @ethereumjs/tx 5, so holding at 2.6
    • removes dependency on legacy ethereum-cryptography v1
  • dedupe and unpin @ethereumjs/tx to ^4.2.0
  • fix(deps): bump [email protected]>^6.5.7 via resolutions
  • fix(deps): bump secp256k

Open in GitHub Codespaces

Related issues

  • https://github.com/GridPlus/eth-lattice-keyring/pull/64
  • https://github.com/GridPlus/gridplus-sdk/issues/547

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

legobeat avatar Oct 18 '24 21:10 legobeat

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 18 '24 21:10 github-actions[bot]

Regarding the remaining deps-audit check:

They released fixes for node-secp256k1 in 4.0.4 and 3.8.1, but older 5.0.0 is still affected.

  • https://github.com/cryptocoinjs/secp256k1-node/issues/208

legobeat avatar Oct 21 '24 22:10 legobeat

Follow-up:

  • #28008

legobeat avatar Oct 29 '24 01:10 legobeat