metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix(deps): @metamask/eth-json-rpc-filters@^8.0.0->^9.0.0

Open legobeat opened this issue 1 year ago • 2 comments

Description

  • deps: @metamask/eth-json-rpc-filters@^8.0.0->^9.0.0

Open in GitHub Codespaces

Related issues

Based on / Blocked by

  • [ ] #27917

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

legobeat avatar Oct 18 '24 11:10 legobeat

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Oct 18 '24 11:10 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +2 372 kB lgbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

socket-security[bot] avatar Oct 18 '24 11:10 socket-security[bot]

Failing unit tests passed after a retry - looks a like an unrelated application flake so putting back in the queue.

Summary of all failing tests
FAIL ui/pages/settings/contact-list-tab/add-contact/add-contact.test.js (10.924 s)
  ● AddContact component › should disable submit button when input is not a valid address

    TypeError: Cannot read properties of undefined (reading 'stage')

      181 |     const trimmedDomainName = domainName.trim();
      182 |     let state = getState();
    > 183 |     if (state[name].stage === 'UNINITIALIZED') {
          |                     ^
      184 |       await dispatch(initializeDomainSlice());
      185 |     }
      186 |     await dispatch(lookupStart(trimmedDomainName));

      at stage (ui/ducks/domains.js:183:21)
      at node_modules/redux-thunk/lib/index.js:23:18
      at dispatch (ui/pages/confirmations/send/send-content/add-recipient/domain-input.container.js:19:23)
      at invokeFunc (node_modules/lodash/lodash.js:10401:23)
      at trailingEdge (node_modules/lodash/lodash.js:10450:18)
      at timerExpired (node_modules/lodash/lodash.js:10438:18)

legobeat avatar Oct 24 '24 03:10 legobeat