metamask-extension
metamask-extension copied to clipboard
fix(deps): @metamask/eth-json-rpc-middleware 15
Description
- deps: @metamask/eth-json-rpc-middleware@^14.0.1-patched->@^15.0.0
- deps: json-rpc-middleware-stream@^5 -> @metamask/json-rpc-middleware-stream@^8
- deps: @metamask/providers@^14.0.2->^18.1.0
Related issues
- #27917
Blocked by
- [x] #22875
- [x] https://github.com/MetaMask/providers/pull/380
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/@metamask/[email protected] | None | +1 |
120 kB | mcmire |
| npm/@metamask/[email protected] | network | 0 |
172 kB | metamaskbot |
| npm/[email protected] | None | 0 |
23.2 kB | lukeed |
🚮 Removed packages: npm/[email protected]
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
Ignoring: npm/@metamask/[email protected]
Next steps
Take a deeper look at the dependency
Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.
Remove the package
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.
Mark a package as acceptable risk
To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all
Blocked by browserify bundling error of inpage contentscript due to now incompatible import of new version of @metamask/providers:
[main] scripts:core:dist:contentscript: Bundling failed! See details below.
[main] scripts:core:dist:contentscript: Error: Can't walk dependency graph: Cannot find module '@metamask/providers/dist/initializeInpageProvider' from '/src/app/scripts/inpage.js'
[main] required by /src/app/scripts/inpage.js
[main] at /src/node_modules/resolve/lib/async.js:146:35
[main] at processDirs (/src/node_modules/resolve/lib/async.js:299:39)
[main] at isdir (/src/node_modules/resolve/lib/async.js:306:32)
[main] at /src/node_modules/resolve/lib/async.js:34:69
[main] at FSReqCallback.oncomplete (node:fs:197:21)
Failure on testcase: 'eth_accounts executes a eth_accounts json rpc call', for more information see the artifacts tab in CI
JavascriptError: javascript error: Cannot read properties of undefined (reading 'request')
(Session info: chrome=126.0.6478.182)
ServerMochaToBackground disconnected from client
manifest-flag-mocha-hooks.ts -- afterEach hook
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="Mocha Tests" time="11.151" tests="1" failures="1">
<testsuite name="Root Suite" timestamp="2024-10-24T04:49:13" tests="0" time="0.000" failures="0">
</testsuite>
<testsuite name="eth_accounts" timestamp="2024-10-24T04:49:13" tests="1" file="/home/circleci/project/test/e2e/json-rpc/eth_accounts.spec.ts" time="11.150" failures="1">
<testcase name="eth_accounts executes a eth_accounts json rpc call" time="11.134" classname="executes a eth_accounts json rpc call">
<failure message="javascript error: Cannot read properties of undefined (reading 'request')
(Session info: chrome=126.0.6478.182)
(Ran on CircleCI Node 0 of 1, Job test-e2e-chrome-rpc)" type="JavascriptError"><![CDATA[JavascriptError: javascript error: Cannot read properties of undefined (reading 'request')
(Session info: chrome=126.0.6478.182)
(Ran on CircleCI Node 0 of 1, Job test-e2e-chrome-rpc)
at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:524:15)
at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:601:13)
at Executor.execute (node_modules/selenium-webdriver/lib/http.js:529:28)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async thenableWebDriverProxy.execute (node_modules/selenium-webdriver/lib/webdriver.js:745:17)
at async /home/circleci/project/test/e2e/json-rpc/eth_accounts.spec.ts:2:1688
at async withFixtures (test/e2e/helpers.js:217:5)
at async Context.<anonymous> (test/e2e/json-rpc/eth_accounts.spec.ts:2:1061)]]></failure>
</testcase>
</testsuite>
</testsuites>
retry() received: Exited with code '1'
Error occurred while running tests on chrome: Error: Retry limit reached
Error: Exited with code '1'
at runInShell (/home/circleci/project/development/lib/run-command.js:134:29)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async main (/home/circleci/project/test/e2e/run-all.js:268:7)
Replaced by https://github.com/MetaMask/metamask-extension/pull/28756 and https://github.com/MetaMask/metamask-extension/pull/28757