metamask-extension
metamask-extension copied to clipboard
MetaMask
draft: network controller v21 + network UI
Description
Related issues
Fixes:
Manual testing steps
- Go to this page...
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/@metamask/[email protected] | None | 0 |
133 kB | metamaskbot |
🚮 Removed packages: npm/@metamask/[email protected]
![socket-security[bot] avatar](https://avatars.githubusercontent.com/in/156372?v=4 "Published by a pub.dev verified publisher"){kind=small}
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
Builds ready [4fb5d45]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1566 ± 60 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 1449 | 1959 | 1572 | 122 | 59 |
| domContentLoaded | 1404 | 1899 | 1550 | 114 | 55 | ||
| load | 1440 | 1963 | 1566 | 124 | 60 | ||
| domInteractive | 13 | 63 | 31 | 12 | 6 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: -7.95 KiB (-0.24%)
- ui: -19.52 KiB (-0.27%)
- common: 15.66 KiB (0.19%)
Codecov Report
Attention: Patch coverage is 75.51020% with 144 lines in your changes missing coverage. Please review.
Project coverage is 70.15%. Comparing base (
97dce9f) to head (d75e942). Report is 3 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #26433 +/- ##
===========================================
- Coverage 70.21% 70.15% -0.05%
===========================================
Files 1445 1442 -3
Lines 50138 49713 -425
Branches 14012 13883 -129
===========================================
- Hits 35200 34875 -325
+ Misses 14938 14838 -100
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Builds ready [b3a97da]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1631 ± 75 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 230 | 1988 | 1478 | 428 | 206 |
| domContentLoaded | 1470 | 1986 | 1615 | 145 | 70 | ||
| load | 1474 | 1991 | 1631 | 157 | 75 | ||
| domInteractive | 12 | 64 | 29 | 12 | 6 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: -7.95 KiB (-0.24%)
- ui: -19.38 KiB (-0.27%)
- common: 15.66 KiB (0.19%)
Builds ready [0461159]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1743 ± 70 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 1562 | 2127 | 1746 | 147 | 70 |
| domContentLoaded | 1551 | 2111 | 1726 | 144 | 69 | ||
| load | 1556 | 2126 | 1743 | 146 | 70 | ||
| domInteractive | 17 | 78 | 41 | 17 | 8 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: -7.94 KiB (-0.24%)
- ui: -19.34 KiB (-0.27%)
- common: 15.66 KiB (0.19%)