metamask-extension
metamask-extension copied to clipboard
[Bug]: send page modal styling broken
Describe the bug
At least three regressions have occurred to the AssetPickerModal component:
- The symbols no longer show for each list item (regressed by #24223)
- Blocked token symbols (e.g., BNB on Ethereum Mainnet) are no longer greyed out in the UI despite still being inert
- Token names are not truncated
Expected behavior
- Symbols should show on top of the token name (see: screenshots)
- Disabled item styling should be restored
- Longer token names should be truncated
Screenshots/Recordings
Current
Expected
Steps to reproduce
- Select Ethereum Mainnet
- Go to Send page
- Click on destination asset picker
- Observe that symbols are not present and names are not truncated
- Search for "BNB"
- Observe that it is not styled as a disabled button
Error messages or log output
No response
Version
12.1.0
Build type
Other (please specify exactly where you obtained this build in "Additional Context" section)
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
Tested on develop
Severity
No response
hey @BZahory , i have a small question regarding the comment below:
Blocked token symbols (e.g., BNB on Ethereum Mainnet) are no longer greyed out in the UI despite still being inert
i want to understand something , Binance coin is an ERC20 deployed on Ethereum mainnet, why should we disable it ( and not allow users to select it ) ?
hey @BZahory , i have a small question regarding the comment below:
Blocked token symbols (e.g., BNB on Ethereum Mainnet) are no longer greyed out in the UI despite still being inerti want to understand something , Binance coin is an ERC20 deployed on Ethereum mainnet, why should we disable it ( and not allow users to select it ) ?
It’s blocked as a swaps token. It should not be disabled as a sending asset, only as a destination asset. The token is still blocked, it is just the design that’s still broken