metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

fix: Add tests for setNetworkClientIdForDomain being called on all network items

Open darkwing opened this issue 1 year ago • 3 comments
trafficstars

Description

Adds tests for the functionality added in https://github.com/MetaMask/metamask-extension/pull/25260

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Run jest tests

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar Jun 12 '24 19:06 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jun 12 '24 19:06 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.62%. Comparing base (e407384) to head (a58af53). Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25270   +/-   ##
========================================
  Coverage    65.62%   65.62%           
========================================
  Files         1372     1372           
  Lines        54512    54512           
  Branches     14281    14281           
========================================
+ Hits         35769    35770    +1     
+ Misses       18743    18742    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 12 '24 21:06 codecov[bot]

Builds ready [a58af53]
Page Load Metrics (46 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681147994
domContentLoaded8191131
load397746105
domInteractive8191131

metamaskbot avatar Jun 12 '24 21:06 metamaskbot

@darkwing test cherry-picked to this PR

salimtb avatar Jul 01 '24 09:07 salimtb

Closing as test was used in https://github.com/MetaMask/metamask-extension/pull/25646

darkwing avatar Jul 09 '24 13:07 darkwing