metamask-extension
metamask-extension copied to clipboard
fix: Add tests for setNetworkClientIdForDomain being called on all network items
Description
Adds tests for the functionality added in https://github.com/MetaMask/metamask-extension/pull/25260
Related issues
Fixes: N/A
Manual testing steps
- Run jest tests
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.62%. Comparing base (
e407384) to head (a58af53). Report is 4 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #25270 +/- ##
========================================
Coverage 65.62% 65.62%
========================================
Files 1372 1372
Lines 54512 54512
Branches 14281 14281
========================================
+ Hits 35769 35770 +1
+ Misses 18743 18742 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [a58af53]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (46 ± 5 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 68 | 114 | 79 | 9 | 4 |
| domContentLoaded | 8 | 19 | 11 | 3 | 1 | ||
| load | 39 | 77 | 46 | 10 | 5 | ||
| domInteractive | 8 | 19 | 11 | 3 | 1 |
@darkwing test cherry-picked to this PR
Closing as test was used in https://github.com/MetaMask/metamask-extension/pull/25646