metamask-extension
metamask-extension copied to clipboard
Fix #22987 - UX - Multichain - Send flow - Select NFTs tab in Asset Picker when an NFT is selected
Description
When the user is in the new send flow and an NFT has been selected as the asset to send, if the user re-opens the AssetPicker, the NFTs tab should display immediately
Related issues
Fixes: #22987
Manual testing steps
- Start the new send flow
- Choose a recipient
- Click the asset picker, choose an NFT as the asset
- Click the asset picker again
- See the NFT tab display by default
Screenshots/Recordings
Before
N/A
After
https://github.com/MetaMask/metamask-extension/assets/46655/5e4bf3ce-05cd-4955-af7a-289d050f6cba
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8ab0637) 68.53% compared to head (8ff5397) 68.53%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #23033 +/- ##
========================================
Coverage 68.53% 68.53%
========================================
Files 1089 1089
Lines 42966 42967 +1
Branches 11440 11441 +1
========================================
+ Hits 29446 29447 +1
Misses 13520 13520
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [8ff5397]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1026 ± 77 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 123 | 566 | 205 | 89 | 43 |
| domContentLoaded | 12 | 101 | 39 | 28 | 13 | ||
| load | 769 | 1379 | 1026 | 160 | 77 | ||
| domInteractive | 12 | 101 | 39 | 28 | 13 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 54 Bytes (0.00%)
- common: 0 Bytes (0.00%)