metamask-extension
metamask-extension copied to clipboard
UX - Multichain - Disconnect All Modal
Description
Creates a simple Disconnect All modal which can be used for both Accounts and Snaps
Related issues
Fixes:
Manual testing steps
Coming soon...
Screenshots/Recordings
Before
Coming soon...
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [bcffd2c]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (783 ± 410 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 75 | 278 | 129 | 48 | 23 |
| domContentLoaded | 10 | 107 | 32 | 21 | 10 | ||
| load | 61 | 1897 | 783 | 855 | 410 | ||
| domInteractive | 10 | 107 | 32 | 21 | 10 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 0 Bytes (0.00%)
- common: 452 Bytes (0.01%)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.72%. Comparing base (
171b6c7) to head (8ebb9ea).
Additional details and impacted files
@@ Coverage Diff @@
## develop #23032 +/- ##
========================================
Coverage 68.72% 68.72%
========================================
Files 1122 1123 +1
Lines 43577 43581 +4
Branches 11661 11661
========================================
+ Hits 29945 29949 +4
Misses 13632 13632
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [8ebb9ea]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1001 ± 401 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 77 | 164 | 118 | 24 | 12 |
| domContentLoaded | 9 | 66 | 28 | 19 | 9 | ||
| load | 63 | 2271 | 1001 | 836 | 401 | ||
| domInteractive | 9 | 66 | 28 | 19 | 9 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 0 Bytes (0.00%)
- common: 452 Bytes (0.01%)