metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

UX - Multichain - Disconnect All Modal

Open darkwing opened this issue 1 year ago • 1 comments

Description

Creates a simple Disconnect All modal which can be used for both Accounts and Snaps

Related issues

Fixes:

Manual testing steps

Coming soon...

Screenshots/Recordings

Before

Coming soon...

After

SCR-20240217-lmpr

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar Feb 17 '24 18:02 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 17 '24 18:02 github-actions[bot]

Builds ready [bcffd2c]
Page Load Metrics (783 ± 410 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint752781294823
domContentLoaded10107322110
load611897783855410
domInteractive10107322110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 452 Bytes (0.01%)

metamaskbot avatar Mar 08 '24 15:03 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.72%. Comparing base (171b6c7) to head (8ebb9ea).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23032   +/-   ##
========================================
  Coverage    68.72%   68.72%           
========================================
  Files         1122     1123    +1     
  Lines        43577    43581    +4     
  Branches     11661    11661           
========================================
+ Hits         29945    29949    +4     
  Misses       13632    13632           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 08 '24 15:03 codecov[bot]

Builds ready [8ebb9ea]
Page Load Metrics (1001 ± 401 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint771641182412
domContentLoaded96628199
load6322711001836401
domInteractive96628199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 452 Bytes (0.01%)

metamaskbot avatar Mar 12 '24 15:03 metamaskbot