metamask-extension
metamask-extension copied to clipboard
nit: useAccountTotalBalance code improvement
Description
Small code improvement. We can simply define the object with its properties instead of adding them one by one.
Related issues
Fixes: N/A
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8ab0637) 68.53% compared to head (3d03d88) 68.53%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #23030 +/- ##
===========================================
- Coverage 68.53% 68.53% -0.00%
===========================================
Files 1089 1089
Lines 42966 42963 -3
Branches 11440 11440
===========================================
- Hits 29446 29443 -3
Misses 13520 13520
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [3d03d88]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1122 ± 90 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 129 | 409 | 216 | 63 | 30 |
| domContentLoaded | 15 | 148 | 54 | 33 | 16 | ||
| load | 797 | 1600 | 1122 | 188 | 90 | ||
| domInteractive | 15 | 148 | 54 | 33 | 16 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: -17 Bytes (-0.00%)
- common: 0 Bytes (0.00%)