metamask-extension
metamask-extension copied to clipboard
Fix #22940 - Remove inline gas components from new send flow
Description
Removes the inline gas components from the new send flow, as they have also been removed from the present send flow.
Related issues
Fixes: #22936
Manual testing steps
MULTICHAIN=1 yarn start- Click "send"
- Select a recipient
- Don't see the old inline gas components.
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9c59da5) 68.54% compared to head (89e4826) 68.54%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #22951 +/- ##
========================================
Coverage 68.54% 68.54%
========================================
Files 1088 1088
Lines 42908 42894 -14
Branches 11414 11412 -2
========================================
- Hits 29410 29401 -9
+ Misses 13498 13493 -5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [89e4826]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1060 ± 57 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 121 | 310 | 199 | 41 | 20 |
| domContentLoaded | 10 | 82 | 40 | 25 | 12 | ||
| load | 919 | 1496 | 1060 | 119 | 57 | ||
| domInteractive | 10 | 82 | 40 | 25 | 12 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: -1.11 KiB (-0.02%)
- common: 0 Bytes (0.00%)