metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Fix #22940 - Remove inline gas components from new send flow

Open darkwing opened this issue 1 year ago • 1 comments

Description

Removes the inline gas components from the new send flow, as they have also been removed from the present send flow.

Related issues

Fixes: #22936

Manual testing steps

  1. MULTICHAIN=1 yarn start
  2. Click "send"
  3. Select a recipient
  4. Don't see the old inline gas components.

Screenshots/Recordings

Before

SCR-20240214-jmuk

After

SCR-20240214-jnjf

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar Feb 14 '24 16:02 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 14 '24 16:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9c59da5) 68.54% compared to head (89e4826) 68.54%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22951   +/-   ##
========================================
  Coverage    68.54%   68.54%           
========================================
  Files         1088     1088           
  Lines        42908    42894   -14     
  Branches     11414    11412    -2     
========================================
- Hits         29410    29401    -9     
+ Misses       13498    13493    -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 03:02 codecov[bot]

Builds ready [89e4826]
Page Load Metrics (1060 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1213101994120
domContentLoaded1082402512
load9191496106011957
domInteractive1082402512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -1.11 KiB (-0.02%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 15 '24 03:02 metamaskbot