metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Fix #7073 - Provide a QR to export private key

Open darkwing opened this issue 1 year ago • 4 comments

Description

It's been requested by many to provide a QR code to export private key in the "Show Private Key" flow. This PR puts a QR code on the private key modal after the user has authenticated password and pressed-to-hold.

Related issues

Fixes: #7073

Manual testing steps

  1. Click the three-dot global menu
  2. Click "Account Details"
  3. Click "Show Private Key"
  4. Enter correct password
  5. Hold the button to reveal key
  6. See the QR code above the text private key
  7. Use a QR reader to read the value
  8. Ensure the output matches the private key

Screenshots/Recordings

Before

N/A

After

Not putting in the PR to not expose any data

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar Feb 09 '24 02:02 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Feb 09 '24 02:02 github-actions[bot]

This PR could likely use security review and advisement

darkwing avatar Feb 09 '24 02:02 darkwing

Builds ready [3c5cebc]
Page Load Metrics (797 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint83117102105
domContentLoaded12332063
load6748897974924
domInteractive12332063
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 429 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 09 '24 02:02 metamaskbot

Builds ready [fbb1db4]
Page Load Metrics (1036 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1252921885024
domContentLoaded973332311
load9181591103616579
domInteractive973332311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 429 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 13 '24 17:02 metamaskbot

Builds ready [903d882]
Page Load Metrics (1870 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint904482109546
domContentLoaded1191382411
load15002389187018689
domInteractive1191382411
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 429 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 20 '24 23:02 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d3f0a32) 68.46% compared to head (903d882) 68.46%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22885   +/-   ##
========================================
  Coverage    68.46%   68.46%           
========================================
  Files         1089     1089           
  Lines        43045    43048    +3     
  Branches     11469    11469           
========================================
+ Hits         29469    29472    +3     
  Misses       13576    13576           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 20 '24 23:02 codecov[bot]