metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

feat: UX: Multichain: Release the send page

Open darkwing opened this issue 1 year ago • 10 comments

Description

Removes the feature flag surrounding the new send flow, as well as removes legacy send files.

Related issues

N/A

Manual testing steps

  1. Go to Send page
  2. See the new UI
  3. Complete a send
  4. Go to an NFT page
  5. Click send
  6. Send the NFT appropriately

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar Jan 08 '24 20:01 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Jan 08 '24 20:01 github-actions[bot]

Blocked on: https://consensyssoftware.atlassian.net/browse/MMASSETS-131

darkwing avatar Jan 12 '24 17:01 darkwing

Presently blocked by: https://github.com/MetaMask/metamask-extension/pull/22551

darkwing avatar Jan 17 '24 15:01 darkwing

@darkwing Does it make sense to you if I add a DO NOT MERGE label and add the Send flow bug fixes epic #2106 as a blocker?

hesterbruikman avatar Feb 28 '24 12:02 hesterbruikman

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.36%. Comparing base (0bac084) to head (224715c).

:exclamation: Current head 224715c differs from pull request most recent head 05fb85e

Please upload reports for the commit 05fb85e to get more accurate results.

Files Patch % Lines
...-list/recipient-group/recipient-group.component.js 75.00% 1 Missing :warning:
...sset-picker-amount/asset-balance/asset-balance.tsx 0.00% 1 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22457      +/-   ##
===========================================
+ Coverage    66.03%   67.36%   +1.33%     
===========================================
  Files         1349     1286      -63     
  Lines        52628    50119    -2509     
  Branches     13523    13007     -516     
===========================================
- Hits         34752    33760     -992     
+ Misses       17876    16359    -1517

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 14:03 codecov[bot]

Builds ready [1eaee9e]
Page Load Metrics (1526 ± 301 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint792251394019
domContentLoaded1588412311
load6622161526627301
domInteractive1587412311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -97.17 KiB (-1.38%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Mar 07 '24 23:03 metamaskbot

Builds ready [3145f46]
Page Load Metrics (1250 ± 417 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint743691426833
domContentLoaded97430189
load6723711250868417
domInteractive97430189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -97.17 KiB (-1.37%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Mar 13 '24 14:03 metamaskbot

Builds ready [62b1b4f]
Page Load Metrics (907 ± 549 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint653621458842
domContentLoaded118328188
load5429929071143549
domInteractive118328188
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -111.02 KiB (-1.74%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Apr 12 '24 17:04 metamaskbot

Builds ready [e4b0f03]
Page Load Metrics (1243 ± 558 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint782091253517
domContentLoaded10101292110
load62283712431161558
domInteractive10101292110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -111.02 KiB (-1.74%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Apr 12 '24 20:04 metamaskbot

Builds ready [224715c]
Page Load Metrics (436 ± 429 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6613184209
domContentLoaded8321363
load542749436893429
domInteractive8321363
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -110.72 KiB (-1.70%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 08 '24 18:05 metamaskbot

Builds ready [bf9afee]
Page Load Metrics (1407 ± 586 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671711072914
domContentLoaded9441584
load63308114071220586
domInteractive9441584
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -110.72 KiB (-1.67%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 22 '24 21:05 metamaskbot

Builds ready [feeeaeb]
Page Load Metrics (613 ± 455 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6012285189
domContentLoaded9491384
load502410613947455
domInteractive8491384
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -110.72 KiB (-1.63%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 25 '24 00:05 metamaskbot

Builds ready [05fb85e]
Page Load Metrics (884 ± 590 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint621771163818
domContentLoaded96125178
load4933028841230590
domInteractive96125178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -110.72 KiB (-1.63%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar May 25 '24 04:05 metamaskbot