metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

UX: Show Total Account Balances

Open darkwing opened this issue 1 year ago • 5 comments

Description

Shows total account balances in the Accounts Menu and home screen overview.

Related issues

Fixes:

Manual testing steps

  1. Open the account list -- see account totals
  2. See the same total on the home overview of each account

Screenshots/Recordings

Before

SCR-20231206-kihi

After

SCR-20231206-kijz

Pre-merge author checklist

  • [ ] I’ve followed MetaMask Coding Standards.
  • [ ] I've clearly explained what problem this PR is solving and how it is solved.
  • [ ] I've linked related issues
  • [ ] I've included manual testing steps
  • [ ] I've included screenshots/recordings if applicable
  • [ ] I’ve included tests if applicable
  • [ ] I’ve documented my code using JSDoc format if applicable
  • [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • [ ] I’ve properly set the pull request status:
    • [ ] In case it's not yet "ready for review", I've set it to "draft".
    • [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing avatar Dec 06 '23 17:12 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Dec 06 '23 17:12 github-actions[bot]

Builds ready [b7db1dd]
Page Load Metrics (1310 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92169106178
domContentLoaded10431673
load1084151113108943
domInteractive10431673
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 326 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Dec 06 '23 18:12 metamaskbot

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (391e9e7) 68.55% compared to head (2e083a8) 68.55%. Report is 2 commits behind head on develop.

Files Patch % Lines
ui/components/app/wallet-overview/eth-overview.js 87.50% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22186   +/-   ##
========================================
  Coverage    68.55%   68.55%           
========================================
  Files         1088     1088           
  Lines        42907    42916    +9     
  Branches     11415    11413    -2     
========================================
+ Hits         29411    29418    +7     
- Misses       13496    13498    +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 06 '23 18:12 codecov[bot]

Builds ready [8ec6020]
Page Load Metrics (803 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92149113147
domContentLoaded9451884
load71410178036431
domInteractive9451884
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 131 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 06 '24 11:02 metamaskbot

Builds ready [3c71afc]
Page Load Metrics (739 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7813098136
domContentLoaded9311753
load6898407393718
domInteractive9311753
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 131 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

metamaskbot avatar Feb 08 '24 17:02 metamaskbot

Builds ready [2e083a8]
Page Load Metrics (930 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1253821904923
domContentLoaded992432813
load84510879305225
domInteractive992432813
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 762 Bytes (0.01%)
  • common: 40 Bytes (0.00%)

metamaskbot avatar Feb 14 '24 14:02 metamaskbot