metamask-extension
metamask-extension copied to clipboard
UX: Show Total Account Balances
Description
Shows total account balances in the Accounts Menu and home screen overview.
Related issues
Fixes:
Manual testing steps
- Open the account list -- see account totals
- See the same total on the home overview of each account
Screenshots/Recordings
Before
After
Pre-merge author checklist
- [ ] I’ve followed MetaMask Coding Standards.
- [ ] I've clearly explained what problem this PR is solving and how it is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
- [ ] I’ve properly set the pull request status:
- [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft".
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [b7db1dd]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1310 ± 43 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 92 | 169 | 106 | 17 | 8 |
| domContentLoaded | 10 | 43 | 16 | 7 | 3 | ||
| load | 1084 | 1511 | 1310 | 89 | 43 | ||
| domInteractive | 10 | 43 | 16 | 7 | 3 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 326 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
391e9e7) 68.55% compared to head (2e083a8) 68.55%. Report is 2 commits behind head on develop.
| Files | Patch % | Lines |
|---|---|---|
| ui/components/app/wallet-overview/eth-overview.js | 87.50% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #22186 +/- ##
========================================
Coverage 68.55% 68.55%
========================================
Files 1088 1088
Lines 42907 42916 +9
Branches 11415 11413 -2
========================================
+ Hits 29411 29418 +7
- Misses 13496 13498 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Builds ready [8ec6020]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (803 ± 31 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 92 | 149 | 113 | 14 | 7 |
| domContentLoaded | 9 | 45 | 18 | 8 | 4 | ||
| load | 714 | 1017 | 803 | 64 | 31 | ||
| domInteractive | 9 | 45 | 18 | 8 | 4 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 131 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [3c71afc]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (739 ± 18 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 78 | 130 | 98 | 13 | 6 |
| domContentLoaded | 9 | 31 | 17 | 5 | 3 | ||
| load | 689 | 840 | 739 | 37 | 18 | ||
| domInteractive | 9 | 31 | 17 | 5 | 3 |
Bundle size diffs
- background: 0 Bytes (0.00%)
- ui: 131 Bytes (0.00%)
- common: 0 Bytes (0.00%)
Builds ready [2e083a8]
- builds: chrome, firefox
- builds (beta): chrome
- builds (flask): chrome, firefox
- builds (MMI): chrome, firefox
- builds (test): chrome, firefox
- builds (test-flask): chrome, firefox
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (930 ± 25 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 125 | 382 | 190 | 49 | 23 |
| domContentLoaded | 9 | 92 | 43 | 28 | 13 | ||
| load | 845 | 1087 | 930 | 52 | 25 | ||
| domInteractive | 9 | 92 | 43 | 28 | 13 |
Bundle size diffs [🚨 Warning! Bundle size has increased!]
- background: 0 Bytes (0.00%)
- ui: 762 Bytes (0.01%)
- common: 40 Bytes (0.00%)