metamask-extension
metamask-extension copied to clipboard
Dark Mode: Elevate the theme dropdown from experimental to regular settings
Explanation
When we feel confident in our dark mode work, we should make it a standard setting, not experimental.
More Information
Requires approval from @kevinghim and/or someone else in product.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
LGTM. Thanks @darkwing !
Builds ready [809bc8e]
- builds: chrome, firefox, opera
- builds (beta): chrome, firefox, opera
- builds (flask): chrome, firefox, opera
- build viz: Build System
- mv3: Background Module Init Stats
- mv3: UI Init Stats
- mv3: Module Load Stats
- mv3: Bundle Size Stats
- mv2: E2e Actions Stats
- code coverage: Report
- storybook: Storybook
- typescript migration: Dashboard
- all artifacts
Page Load Metrics (1327 ± 59 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 88 | 134 | 107 | 12 | 6 |
| domContentLoaded | 1201 | 1600 | 1296 | 112 | 54 | ||
| load | 1201 | 1619 | 1327 | 123 | 59 | ||
| domInteractive | 1201 | 1600 | 1296 | 112 | 54 |
highlights:
storybook
- ui/pages/settings/advanced-tab/advanced-tab.stories.js
- ui/pages/settings/contact-list-tab/contact-list-tab.stories.js
- ui/pages/settings/flask/snaps-list-tab/snap-list-tab.stories.js
- ui/pages/settings/info-tab/info-tab.stories.js
- ui/pages/settings/networks-tab/networks-list-item/networks-list-item.stories.js
- ui/pages/settings/networks-tab/networks-list/network-list.stories.js
- ui/pages/settings/settings.stories.js
@darkwing should this be merged or should we throw a DO NOT MERGE label on?