metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

[i18n:eu] Add Euskara language support

Open darkwing opened this issue 4 years ago • 5 comments

Superecedes https://github.com/MetaMask/metamask-extension/pull/12063 to fix lint.

darkwing avatar Nov 10 '21 19:11 darkwing

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Nov 10 '21 19:11 github-actions[bot]

Builds ready [4bc5cab]
Page Load Metrics (645 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5297216434119
domContentLoaded5167236434521
load5467246453919
domInteractive5167236434521

highlights:

storybook

metamaskbot avatar Nov 10 '21 20:11 metamaskbot

Should probably wait until #13206 is merged before merging this.

mcmire avatar Jan 07 '22 00:01 mcmire

Seems #13206 is merged.

But I am not sure if we should add this language as it is not supported by crowdin and will be hard to maintain.

jpuri avatar Feb 01 '22 14:02 jpuri

@jpuri I think it's okay to have languages not supported by Crowdin. That means that the community will have to maintain them, but I think that's fine. Also, this language shouldn't conflict with any PRs Crowdin gives us. Agree/disagree?

mcmire avatar Feb 01 '22 18:02 mcmire