metamask-extension
metamask-extension copied to clipboard
[i18n:eu] Add Euskara language support
Superecedes https://github.com/MetaMask/metamask-extension/pull/12063 to fix lint.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Builds ready [4bc5cab]
Page Load Metrics (645 ± 19 ms)
| Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 529 | 721 | 643 | 41 | 19 |
| domContentLoaded | 516 | 723 | 643 | 45 | 21 | ||
| load | 546 | 724 | 645 | 39 | 19 | ||
| domInteractive | 516 | 723 | 643 | 45 | 21 |
highlights:
storybook
- ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
- ui/pages/confirm-approve/confirm-approve.stories.js
- ui/pages/confirm-deploy-contract/confirm-deploy-contract.stories.js
- ui/pages/confirm-encryption-public-key/confirm-encryption-public-key.stories.js
- ui/pages/confirm-import-token/confirm-import-token.stories.js
- ui/pages/confirm-send-ether/confirm-send-ether.stories.js
- ui/pages/confirm-token-transaction-base/confirm-token-transaction-base.stories.js
- ui/pages/settings/settings.stories.js
Should probably wait until #13206 is merged before merging this.
Seems #13206 is merged.
But I am not sure if we should add this language as it is not supported by crowdin and will be hard to maintain.
@jpuri I think it's okay to have languages not supported by Crowdin. That means that the community will have to maintain them, but I think that's fine. Also, this language shouldn't conflict with any PRs Crowdin gives us. Agree/disagree?