etherscan-link icon indicating copy to clipboard operation
etherscan-link copied to clipboard
verified publisher icon MetaMask

devDeps: upgrade test & lint suite

Open legobeat opened this issue 2 years ago • 12 comments

This upgrades test and lint packages, bringing in configuration in direction of https://github.com/MetaMask/metamask-module-template/.

Migrating to jest and fixing jsdoc comments left as separate changes. Otherwise updated linting rules have been applied.

legobeat avatar May 14 '23 22:05 legobeat

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar May 14 '23 22:05 socket-security[bot]

@SocketSecurity ignore @metamask/[email protected] @SocketSecurity ignore @metamask/[email protected] @SocketSecurity ignore @metamask/[email protected] @SocketSecurity ignore @metamask/[email protected]

legobeat avatar May 14 '23 22:05 legobeat 

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Let's see if they pick up https://github.com/typicode/please-upgrade-node/pull/36

legobeat avatar May 15 '23 04:05 legobeat 

@SocketSecurity ignore @babel/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

We know you guys

legobeat avatar May 15 '23 04:05 legobeat 

@SocketSecurity ignore @vue/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @ungap/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @types/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

Many of these look to be eternal until they're removed from entrypoint packages (cf https://github.com/inspect-js/is-typed-array/pull/54#issuecomment-1547171507)

I'm as much for backwards-compat as the next person but with a network of interconnected micropackages all maintained with this approach underpinning the linting, I have a feeling this can get uncomfortable over time.

legobeat avatar May 15 '23 04:05 legobeat

Blocked by https://github.com/MetaMask/eslint-config/pull/290

legobeat avatar May 15 '23 09:05 legobeat 

@SocketSecurity ignore [email protected]

legobeat avatar May 15 '23 09:05 legobeat

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment +10 192 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.89 MB nicolo-ribaudo
npm/@babel/[email protected] environment +3 2.49 MB nicolo-ribaudo
npm/@eslint-community/[email protected] None 0 431 kB eslint-community-bot
npm/@jridgewell/[email protected] None 0 45.9 kB jridgewell
npm/@jridgewell/[email protected] None +1 219 kB jridgewell
npm/@metamask/[email protected] None 0 8.58 kB metamaskbot
npm/@metamask/[email protected] None 0 94.8 kB metamaskbot
npm/@metamask/[email protected] None 0 18.5 kB metamaskbot
npm/@metamask/[email protected] None 0 119 kB metamaskbot
npm/@nodelib/[email protected] filesystem 0 11.8 kB mrmlnc
npm/@nodelib/[email protected] Transitive: filesystem +5 107 kB mrmlnc
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +23 6.39 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +13 2.01 MB jameshenry
npm/[email protected] None +4 81.5 kB ljharb
npm/[email protected] None 0 11.7 kB sindresorhus
npm/[email protected] environment 0 42.4 kB qix
npm/[email protected] None +2 47.5 kB ljharb
npm/[email protected] None +2 50 kB ljharb
npm/[email protected] filesystem, unsafe Transitive: environment, eval +61 9.49 MB rumpl
npm/[email protected] None 0 19.9 kB lydell
npm/[email protected] filesystem, unsafe Transitive: environment, network +63 5.68 MB ljharb
npm/[email protected] None +8 2.53 MB gajus
npm/[email protected] None +3 1.24 MB lo1tuma
npm/[email protected] filesystem +10 1.57 MB weiran.zsd
npm/[email protected] None +2 120 kB jounqin
npm/[email protected] None 0 67.1 kB eslint-community-bot
npm/[email protected] None 0 32.3 kB eslintbot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +56 8.18 MB eslintbot
npm/[email protected] None +2 629 kB eslintbot
npm/[email protected] None 0 1 MB michaelficarra
npm/[email protected] Transitive: environment, filesystem +2 20.6 kB doowb
npm/[email protected] Transitive: filesystem +5 43.7 kB sindresorhus
npm/[email protected] eval +3 89.4 kB ljharb
npm/[email protected] filesystem Transitive: environment +9 109 kB isaacs
npm/[email protected] None 0 20.6 kB ljharb
npm/[email protected] None 0 51.2 kB kael
npm/[email protected] None 0 11.9 kB ljharb
npm/[email protected] None 0 28.9 kB ljharb
npm/[email protected] None +2 72.5 kB ljharb
npm/[email protected] None +1 19.8 kB phated
npm/[email protected] None +1 30 kB ljharb
npm/[email protected] None 0 17.6 kB ljharb
npm/[email protected] None 0 54.5 kB ljharb
npm/[email protected] environment, eval, filesystem Transitive: shell +33 5.55 MB juergba
npm/[email protected] None 0 97.2 kB ljharb
npm/[email protected] None 0 90 kB mrmlnc
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] filesystem 0 20.5 kB paulmillr
npm/[email protected] Transitive: environment, filesystem +8 73.1 kB phated
npm/[email protected] environment, filesystem +2 159 kB ljharb
npm/[email protected] None +2 58.4 kB sindresorhus
npm/[email protected] None +1 9.64 kB sindresorhus
npm/[email protected] None 0 68.8 MB typescript-bot
npm/[email protected] None +4 80.4 kB ljharb
npm/[email protected] environment, filesystem 0 120 kB oss-bot
npm/[email protected] environment, filesystem +6 379 kB oss-bot

🚮 Removed packages: npm/@metamask/[email protected], npm/@nodelib/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Nov 18 '23 11:11 socket-security[bot]

  • Rebased on main
  • Bumped depcheck to latest
  • Bumped @metamask/eslint* to latest and align peerDeps

legobeat avatar Nov 18 '23 11:11 legobeat 

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

new author ok

legobeat avatar Nov 18 '23 11:11 legobeat 

@SocketSecurity ignore [email protected]

"unpublished" ?

legobeat avatar Nov 18 '23 11:11 legobeat 

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

new author ok

legobeat avatar Apr 22 '24 09:04 legobeat