eth-phishing-detect icon indicating copy to clipboard operation
eth-phishing-detect copied to clipboard

Remove inactive blocklist entries

Open stanleyjzheng opened this issue 1 year ago • 8 comments

On behalf of https://github.com/blowfishxyz

Please do not merge this PR yet.

stanleyjzheng avatar Mar 12 '24 12:03 stanleyjzheng

Will need to merge https://github.com/MyEtherWallet/ethereum-lists/pull/2107 to fix CI first.

stanleyjzheng avatar Mar 12 '24 12:03 stanleyjzheng

do not merge until @blurpesec has approved

tayvano avatar Mar 12 '24 20:03 tayvano

Wondering what the logic is to remove domains? I notice some that I have only added a few days ago. I assume it's if DNS simply doesn't resolve?

A lot that I had added were sourced from Cert Transparency, so they have simply not completed setup of the phishing kits, but they likely will rotate their campaigns onto those soon.

jonade avatar Mar 16 '24 10:03 jonade

@409H are you able to resolve the merge conflict and merge?

AlexHerman1 avatar Apr 25 '24 21:04 AlexHerman1

@409H are you able to resolve the merge conflict and merge?

Brought the branch up to today, though will be outdated due to SEAL bot constantly merging into main. We need to fix the MEWlist CI check and update the branch again when we are ready to merge it

409H avatar Apr 29 '24 18:04 409H

@409H are you able to resolve the merge conflict and merge?

Brought the branch up to today, though will be outdated due to SEAL bot constantly merging into main. We need to fix the MEWlist CI check and update the branch again when we are ready to merge it

Appreciate it. Have a PR up to fix the MEWlist CI here: https://github.com/MyEtherWallet/ethereum-lists/pull/2107

stanleyjzheng avatar Apr 29 '24 18:04 stanleyjzheng

@stanleyjzheng that repo seems to be relatively unmaintained (4 commits in the last year). I'll issue a PR to your branch to remove this CI check

409H avatar Apr 30 '24 18:04 409H

Do we still need @blurpesec to review @tayvano ?

409H avatar Apr 30 '24 18:04 409H