core

core copied to clipboard

Create EthereumAddress interface and class

1

By having an interface EthereumAddress we can forget about all the type related issues (string vs hex, etc). If we have an EthereumAddress obj also we could call toChecksumAddress inside...

brunobar79

Review all controllers for offline use

1

We should verify what happens to controllers when connectivity goes down and make sure they can resume peacefully. Is this something we handle higher up int he stack, like at...

bitpshr

Adds the `noUncheckedIndexedAccess` TypeScript compiler flag to the repo-wide package `tsconfig.json`. Ref: https://github.com/MetaMask/metamask-module-template/pull/84 The following controllers must be updated to resolve issues with this rule: - [x] AddressBookController (8914b53) -...

rekmarks

excessive use of safelyExecute

2

should be used sparingly, eg only by polling handlers

kumavis

For some time, Jest has been complaining about unfinished async operations when tests end. The recommended way to understand what those operations are is the `--detectOpenHandles` flag, which is broken...

rekmarks

This test demonstrates that BaseControllerV2 is not as type-safe as we would like, because of the `any`'s passed into the RestrictedControllerMessenger. Specifically, we don't check that the required Event type...

Gudahtt

I would love to be able to store my seed phrase in a paper with the peace of mind that if someone discovers it, I'm safe because they don't have...

nicolasbenenzon

We should find some way to unit test some of our more complex types, to ensure they're guaranteeing exactly what we think they are. In particular, the types used by...

Gudahtt

The `publish-release` action now uses the same installation method as the lint/build step. This should make the output more predictable, and there is a greater chance that it will match...

Gudahtt

mcmire