core icon indicating copy to clipboard operation
core copied to clipboard

add methods required by smart transaction controller (patch v7)

Open vinistevam opened this issue 1 year ago • 1 comments

Explanation

References

Changelog

@metamask/package-a

  • <CATEGORY>: Your change here
  • <CATEGORY>: Your change here

@metamask/package-b

  • <CATEGORY>: Your change here
  • <CATEGORY>: Your change here

Checklist

  • [ ] I've updated the test suite for new or updated code as appropriate
  • [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate

vinistevam avatar Feb 20 '24 11:02 vinistevam

Hi! I noticed that all of the eslint-disable directives and TODOs for converting interfaces to type aliases have been removed in this PR.

The shared libraries team relies on those comments to mark interface instances that were pre-existing at the time we enabled @typescript-eslint/consistent-type-definitions, and to keep track of remaining interfaces that need to be converted.

We'd appreciate it if you could restore them in this PR before you mark it as ready for review.

Additionally, any new types being added should be in the form of type aliases, not interfaces.

Please refer to the following for previous discussions on this matter:

  • https://github.com/MetaMask/eslint-config/pull/216
  • https://github.com/MetaMask/core/pull/1933

Edit: This PR seems to supersede https://github.com/MetaMask/core/pull/3900, but if not, please apply the same to that and any previous PRs as well.

Edit2: Is this PR maybe not intended to be merged into core?

MajorLift avatar Feb 27 '24 03:02 MajorLift