Messj1

@kesselb I don't see the reasons to make those changes since they don't improve or fix something. Maybe unofficial guideline? The developer manual itself has contains no chapter how to...

> https://stackoverflow.com/questions/6083248/is-it-a-bad-practice-to-catch-throwable is a good read. > > You need to be as specific as possible. Otherwise unforeseen bugs might creep away this way. > > Besides, Throwable covers Error...

There is another unhandled case with `null` as return value from `getLocalFile`. View.php ```php public function getLocalFile($path) { ... if (Filesystem::isValidPath($parent) and $storage) { return $storage->getLocalFile($internalPath); } else { return...

One thing I would change is the logic with has Certificates. Currently if there are no certificates it caches the "system" ca bundle. And then it tries to write it...

@kesselb So it is like it now is. An Error :smile: The CI pipeline errors are not mine: - Still problem with cloning (this time the submodul) - Performance test...

@kesselb I forgot to sign all my commits. They are not verified in github. Should I sign them with rebase and use force push to correct it?

@pserwylo What went wrong on performance testing? https://github.com/nextcloud/server/actions/runs/3644023086/jobs/6158316871 If works local on my computer without warnings and error if I try to reproduce the error. :unamused:

rebased and solved merge conflict.

@ solracsf Is this problem is related to #1056 ? Can you Check if following commit helps: 8facb65a39e4a49e11255acd417e06f3ec016f45

Think there could be a cleaner solution that fits the case: Revert changes: ```diff + $oldUsers = $this->oldAccessList['users']; - $oldUsers = $this->oldAccessList['users'] ?? []; ... + $beforeRemotes = $this->oldAccessList['remotes']; -...