diagnose
diagnose copied to clipboard
Mesabloo
Add CI
Add a Github Action CI Build matrix for Windows + Mac + Ubuntu.
Thanks!
I'll wait a bit before merging this PR.
Given the current state of the wcwidth package on Hackage, I'd rather not include CI if it will fail for at least Windows at the moment.
Hopefully we get an update soon...otherwise I'll resort to including wcwidth inside the library (in a hidden module probably) and we'll see after that!
Our temporary fix is to add the wcwidth Github repo as an extra dependency in our stack configuration: https://github.com/duo-lang/duo-lang/pull/491
We hope to remove that workaround once wcwidth has been fixed upstream and a new version uploaded to Hackage.
I think it might be a good idea to do the same here, and also to document it (until a new version of wcwidth is uploaded to Hackage) for other users.
However, a quick question before: from what I see in the stack.yaml file, you are using the latest commit made to wcwidth. Does it work with spaces? As far as we have discussed in https://github.com/Mesabloo/diagnose/issues/11#issuecomment-1236385494, the fix should be pretty easy but I don't see it fixed there.
Let's merge this, but we know that currently, Windows support for wcwidth (at least the officially published package) is a bit lacking.
Would you mind commenting out windows-latest in the build matrix? I'll merge this right after. Or a better solution would be to add the dependency in the stack.yaml file?
Either way, I'll add a warning in the README once this is merged.
Thanks!
Sorry, it took me quite a while to come back to this. I have written to the maintainer of wcwidth and have asked to take over maintenance of the wcwidth package on Hackage. If that works out then I will be able to release a new version of wcwidth on Hackage, and properly fix diagnose on Windows.