mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

Add default config tests for the A64, A32, Thumb 1 and Thumb 2 instruction sets

Open bensze01 opened this issue 1 year ago • 5 comments

Description

This PR adds default-config tests for A64, A32, Thumb 1 and Thumb 2 instruction sets.

The components are only enabled, if the host machine is capable of running the binaries produced by the (cross) compiler.

The corresponding PR Mbed-TLS/mbedtls-test#171 needs to be merged before this one

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • [ ] changelog Not required - test changes only
  • [ ] 3.6 backport required
  • [ ] 2.28 backport required
  • [ ] tests provided

bensze01 avatar Jul 11 '24 22:07 bensze01

Does this need to be updated following the split of all.sh?

tom-cosgrove-arm avatar Aug 07 '24 15:08 tom-cosgrove-arm

@tom-cosgrove-arm Rebased the PR on top of development.

bensze01 avatar Aug 08 '24 16:08 bensze01

Removed needs-preceding-pr since it's been merged

tom-cosgrove-arm avatar Sep 25 '24 07:09 tom-cosgrove-arm

@bensze01 That's a near-approval from me, so I think you can start working on the backports.

@tom-cosgrove-arm Will you be able to review the backports or should I look for another reviewer?

mpg avatar Oct 10 '24 10:10 mpg

I can review backports

tom-cosgrove-arm avatar Oct 10 '24 15:10 tom-cosgrove-arm

@bensze01 Looks like #9657 is going to be merged first (just added it the merge queue), so this will need a rebase or a merge in order to resolve the conflicts. Whatever strategy you choose, I think in the end the new functions like gcc_version() and can_run_xxx() should end up in all-helpers.sh (together with the existing clang_version()).

Then this will need a backport. Let's get this merged, we're almost there!

mpg avatar Oct 22 '24 13:10 mpg

@tom-cosgrove-arm @mpg I think I've addressed all review comments - please re-review!

bensze01 avatar Oct 28 '24 11:10 bensze01

Note: the failures of the armcc components on OpenCI are unrelated to this PR (issues with the license server).

mpg avatar Oct 28 '24 11:10 mpg

Added backports:

  • 3.6: #9733
  • 2.28: #9734

bensze01 avatar Oct 28 '24 13:10 bensze01