mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

Published 20 hours ago • verified publisher icon Mbed-TLS

TLS 1.3: Add support for trusted certificate callback

Open ronald-cron-arm opened this issue 1 year ago • 3 comments

Description

Fix #7079

PR checklist

  • [ ] changelog required, TODO
  • [ ] 3.6 backport required, TODO
  • [x] 2.28 backport done, or not required
  • [x] tests provided

ronald-cron-arm avatar Apr 03 '24 07:04 ronald-cron-arm

Just one question for my own education (no impact on this PR): why is the cert verification code not common between 1.3 and 1.2?

mpg avatar Apr 08 '24 09:04 mpg

Just one question for my own education (no impact on this PR): why is the cert verification code not common between 1.3 and 1.2?

I have been wondering the same when working on this PR and I think there is no good reason. There are some differences (key usage checks for example I think) but most of the code in common. I've considered doing it in this PR but decided eventually that I did not have enough time to do it. I am creating an issue to not forget about it: #9018.

ronald-cron-arm avatar Apr 09 '24 07:04 ronald-cron-arm

This fixes things for us, thanks!

wyattoday avatar Apr 17 '24 17:04 wyattoday

Closing this pull request as we prefer to address the more general #9018 issue rather than #7079.

ronald-cron-arm avatar Jul 19 '24 12:07 ronald-cron-arm