scale number of jobs

[realies]

for faster builds

[MatthewVance]

Thanks for the suggestion. I had thought about including that flag for speed, but left it off for security purposes since this includes building a crypto library. I'm not sure it's unsafe in every scenario, but prefer to play it safe at the expense of a slower compile time.

On Fri, Jul 6, 2018, 5:00 AM realies [email protected] wrote:

for faster builds

You can view, comment on, or merge this pull request online at:

https://github.com/MatthewVance/nginx-build/pull/56 Commit Summary

• make jobs 4

File Changes

• M build-nginx.sh https://github.com/MatthewVance/nginx-build/pull/56/files#diff-0 (2)

Patch Links:

• https://github.com/MatthewVance/nginx-build/pull/56.patch
• https://github.com/MatthewVance/nginx-build/pull/56.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MatthewVance/nginx-build/pull/56, or mute the thread https://github.com/notifications/unsubscribe-auth/ACjDuq_o0wZacK2MqUiH98F6MEZjgLYCks5uDzU_gaJpZM4VFNCd .

[realies]

Doesn't make a difference to the binary.

[MatthewVance]

Perhaps, but OpenSSL has had a history of make periodically failing to work with -j so even if the binaries are the same using the flag is not the safest option. The current versions appear to have it resolved for now, but who knows if that'll last: https://github.com/intel/intel-sgx-ssl/issues/4 https://github.com/openssl/openssl/issues/5762 https://github.com/openssl/openssl/issues/2331 https://github.com/openssl/openssl/issues/298

Also, LibreSSL has a warning in their configure file about -j potentially being unsafe if the -c and -o of $CC is not supported. That's probably rare, but something to keep in mind. https://fossies.org/linux/libressl/configure

If this was going to be included in the script, the number associated with -j should be dynamically determined based on processor cores + 1 since this is designed to work on a variety of hardware.

On Fri, Jul 6, 2018, 6:38 AM realies [email protected] wrote:

Doesn't make a difference to the binary.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MatthewVance/nginx-build/pull/56#issuecomment-403009264, or mute the thread https://github.com/notifications/unsubscribe-auth/ACjDurI77r29cgQ53-w34k729gQQhYHzks5uD0xKgaJpZM4VFNCd .