Wordpress-Timthumb-alternative icon indicating copy to clipboard operation
Wordpress-Timthumb-alternative copied to clipboard

Reduced DB calls to only when image is first created, added Quality setting for ImageMagick

Open styledev opened this issue 12 years ago • 3 comments
trafficstars

...hitting the DB when the image already exists. Also added $quality attribute for ImageMagick version.

styledev avatar Feb 18 '13 23:02 styledev

Looks good, but all of the code indentation and formatting seems a bit off. Is this intentional? Bit of a Git noob here so not sure if I can correct it before merging.

Awesome work none-the-less, thanks for the contribution :)

MatthewRuddy avatar Feb 19 '13 01:02 MatthewRuddy

Oh, yeah. I indented all of the code so it would fold properly. The biggest thing though is just moving the DB call inside of file_exists which you could do on your own. And then for imagemagick adding the $quality = false variable to the function call and adding in the appropriate code noted in the creation step in my new code.

Dewey Bushaw Co-Founder of Parapxl Corp. www.parapxl.com

w. 949-276-3831

On Monday, February 18, 2013 at 5:57 PM, MatthewRuddy wrote:

Looks good, but all of the code indentation and formatting seems a bit off. Is this intentional? Bit of a Git noob here so not sure if I can correct it before merging.

— Reply to this email directly or view it on GitHub (https://github.com/MatthewRuddy/Wordpress-Timthumb-alternative/pull/5#issuecomment-13753036).

styledev avatar Feb 19 '13 02:02 styledev

:+1:

aristath avatar Sep 21 '13 10:09 aristath