MathisGD comments

Results 17 comments of


                                            MathisGD

expectedSupplyAssets behaving differenly locally and in CI-CD pipeline (gitlab)

Feel free to reach out if you still have issues

Inconsistent naming of "MainnetLib"

So we modify the contract without redeploying it? Then I would also modify "BaseBundler"

Inconsistent naming of "MainnetLib"

Why not renaming the "BaseBundler"?

include ERC72.huff got duplicate macro name

I believe that this is linked to the change in huffc which raises an error when there are duplicate macros in a compiled file (including imports), while in the past...

feat(cheatcodes): add `vm.storeTransient` and `vm.loadTransient`

It would be great to have a vm.clearTransientStorage() cheat as well, like mentioned here: https://github.com/foundry-rs/foundry/issues/6908

Fix: total supply overflow

> There are two APPROVE() macros. Removed the old incorrect macro. I opened an [issue](https://github.com/huff-language/huff-rs/issues/291) on huff-rs for this.

scripts: deployer of script contract is not msg.sender

EOAs can't directly use CREATE2, although they can call a contract that does a CREATE2. When a CREATE2 is in a forge script, the transaction is actually a call to...