Mathieu Duponchelle

Results 137 comments of Mathieu Duponchelle
trafficstars

hrm, @massis08 this is a bit of a mess :)

@massis08 yes, Merge Requests should be as atomic as possible. Also you should try to answer questions from reviewers, it otherwise makes reviews pretty pointless ;) https://github.com/centricular/webrtcsink/pull/75#pullrequestreview-1044072059

Closed in favor of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/257

Also note that this all makes me think of `GInitable`, which exists specifically for fallible constructors, https://docs.gtk.org/gobject/tutorial.html#object-construction goes as far as explicitly stating that `It is important to note that...

I don't know what my own conclusion here is to be honest :) I think a `try` version would be useful, ideally with a more descriptive return value than just...

Well, you're describing the difference between EAPF and LBYL, and I don't know what the preferred approach is with rust :) Re what I would do, I don't know, like...

> I think the bigger question here is: Is there any use case where it makes sense to handle the `Err` case without a panic where it wouldn't have been...