Matheus Richard

Results 109 comments of Matheus Richard

I don't think the convenience will pay-off the edge case we're introducing. Let's hear it from the core team. @northeastprince you'll need to add tests and a changelog entry if...

Some on core has to approve and merge it. Try highlighting this PR in the Rails Discord.

Related: https://github.com/asdf-vm/asdf-ruby/issues/447

I just moved to [mise](https://mise.jdx.dev/) instead. Not the solution to this problem, the [migration is pretty easy](https://mise.jdx.dev/faq.html#how-do-i-migrate-from-asdf).

Some more investigation. If I change it to ```cr if other.is_a?(self) # returns true! return @elements == other.elements end ``` Shouldn't `is_a?` [only receive classes](https://github.com/crystal-lang/crystal/blob/d2369ac2e/src/docs_pseudo_methods.cr#L158)? I tried calling random methods...

@ysbaddaden that makes sense. It _sounds_ like a bug to me, but now I'm confused whether this is the expected behavior

@straight-shoota I'm happy to provide a PR, if you can give me any pointers.

This fixed it for me: ```sh $ rm -r ~/.asdf/installs/ruby/3.4.3 $ ASDF_RUBY_BUILD_VERSION=master asdf install ruby 3.4.3 ```

I have yet to check the search code, but I want to highlight that rails have some potential useful sanitization methods: https://api.rubyonrails.org/classes/ActiveRecord/Sanitization/ClassMethods.html#method-i-sanitize_sql_like

@JoeDupuis please add a changelog entry